Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Aug 1995 15:43:38 -0700 (PDT)
From:      "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
To:        peter@haywire.dialix.com (Peter Wemm)
Cc:        CVS-commiters@freefall.FreeBSD.org, cvs-usrsbin@freefall.FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin Makefile
Message-ID:  <199508132243.PAA11367@gndrsh.aac.dev.com>
In-Reply-To: <Pine.SV4.3.91.950814062031.15693I-100000@haywire.DIALix.COM> from "Peter Wemm" at Aug 14, 95 06:35:43 am

next in thread | previous in thread | raw e-mail | index | archive | help
> 
> On Sun, 13 Aug 1995, Rodney W. Grimes wrote:
> > > peter       95/08/13 08:28:20
> > > 
> > >   Modified:    usr.sbin  Makefile
> > >   Log:
> > >   Add sicontrol.. I hope this is the right way..
> > 
> > When ever you have to say things like that, please send the patch out
> > for review before commiting it. 
> 
> Sorry..  that was badly worded and not what I was thinking of... I knew
> what I had entered was in line with what everybody else had done, I was
> going to make a comment about the ordering in the file being inconsistant
> (the cleandir and i386 conditionals had a couple of entries out of
> alphabetical order.. no big deal), but Tristan (8 months old) decided that
> right that instant that I started the log message was a good time to wake up 
> and demand a feed (it was about 3am or so, and he's currently rather 
> unwell), and that's what blurted out while I was distracted.. 

:-)  Understood.

> 
> I didn't want to risk aborting the commit, as some versions of cvs do 
> stranger things than others..  I couldn't leave it there, as it'd leave 
> the directory locked for an hour..  So we ended up with a 
> not-very-confidence-inspiring commit message.. Sorry..

The version of cvs running on freefall will handle a q!, abort operation
just fine.  I have done it on so many occasions I don't care to count
them any more.  If we ever do get a version of cvs that fails this, it
would be a class A1 bug in my book, meaning fix it today, or as fast as
we can.

I often get in to the commit, see the CVS: lines are not what I expected
and abort the commit to go fix my mistake.  [Often cvs add, or cvs remove
commands forgotten].


Which reminds me, did you ever get any feedback from the cvs group to
that small bug fix for 0 lenght RCS files in the repository?  We still
need to commit a fix and get a new version of cvs installed on freefall.

-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                 Reliable computers for FreeBSD



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508132243.PAA11367>