From owner-freebsd-current  Tue Jan 28  6:39:30 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B2E4937B401; Tue, 28 Jan 2003 06:39:28 -0800 (PST)
Received: from watery.cc.kogakuin.ac.jp (watery.cc.kogakuin.ac.jp [133.80.152.80])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 12D7143F43; Tue, 28 Jan 2003 06:39:28 -0800 (PST)
	(envelope-from nyan@jp.FreeBSD.org)
Received: from localhost (localhost [IPv6:::1])
	by watery.cc.kogakuin.ac.jp (8.12.6/8.12.6) with ESMTP id h0SEdRxR057132;
	Tue, 28 Jan 2003 23:39:27 +0900 (JST)
	(envelope-from nyan@jp.FreeBSD.org)
Date: Tue, 28 Jan 2003 23:38:56 +0900 (JST)
Message-Id: <20030128.233856.71130419.nyan@jp.FreeBSD.org>
To: jmallett@FreeBSD.ORG, obrien@FreeBSD.ORG
Cc: current@FreeBSD.ORG, peter@FreeBSD.ORG, ru@FreeBSD.ORG
Subject: Re: Patch to teach config(8) about "platforms".
From: Takahashi Yoshihiro <nyan@jp.FreeBSD.org>
In-Reply-To: <20030125153116.A25743@FreeBSD.org>
References: <20030125153116.A25743@FreeBSD.org>
X-Mailer: Mew version 3.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

In article <20030125153116.A25743@FreeBSD.org>
Juli Mallett <jmallett@FreeBSD.ORG> writes:

> For example "platform sgimips" implies
> "options SGIMIPS".  Below are patches to makefile glue and config(8)
> itself.

I think that using '#ifdef <machine>' (like #ifdef PC98) is not a good
idea.  If it requires, the file should be splited into sys/<machine>.
I'll split some files in sys/i386 into sys/pc98.


> For clarity, this is used in cases where the platform may define its
> own values that a header needs, and as such, you might see something
> in <machine/endian.h> like:
> #include <platform/endian.h>

How about next way?

- Install sys/${MACHINE}/include into /usr/include/${MACHINE}
- Symlink /usr/include/machine -> /usr/include/${MACHINE}
- If ${MACHINE} != ${MACHINE_ARCH},
  install sys/${MACHINE_ARCH}/include into /usr/include/${MACHINE_ARCH}

For example, sys/pc98/include/endian.h is '#include <i386/endian.h>'
only.

---
TAKAHASHI Yoshihiro <nyan@FreeBSD.org>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message