Date: Tue, 23 Dec 2014 15:37:59 -0700 From: Ian Lepore <ian@freebsd.org> To: Larry Rosenman <ler@lerctr.org> Cc: freebsd-arm@freebsd.org Subject: Re: lsof on FreeBSD/arm Message-ID: <1419374279.1018.144.camel@freebsd.org> In-Reply-To: <48ad36516ffbabbecf6ab3c53031bfb3@thebighonker.lerctr.org> References: <dfbaf5451abce25b512efe4f8c80ff58@thebighonker.lerctr.org> <1419362189.1018.138.camel@freebsd.org> <c9bcab9ff5aa4a67ec290908e72a53c9@thebighonker.lerctr.org> <1419367656.1018.142.camel@freebsd.org> <48ad36516ffbabbecf6ab3c53031bfb3@thebighonker.lerctr.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2014-12-23 at 16:29 -0600, Larry Rosenman wrote: > On 2014-12-23 14:47, Ian Lepore wrote: > > On Tue, 2014-12-23 at 14:02 -0600, Larry Rosenman wrote: > >> On 2014-12-23 13:16, Ian Lepore wrote: > >> > On Tue, 2014-12-23 at 11:29 -0600, Larry Rosenman wrote: > >> >> Greetings, > >> >> I'm the maintainer of the sysutils/lsof port for FreeBSD. It's > >> >> been > >> >> reported to me that the port doesn't compile on arm. In investigating > >> >> that, I found that some of the includes that lsof includes need a cpu > >> >> type defined in order to compile (machine/cpuconf.h). > >> >> > >> >> Is there a reason that there is no "default" cpu defined either by the > >> >> compiler or environment? > >> >> > >> >> Playing in a armv6 poudriere jail, I found I can get it to compile > >> >> via: > >> >> borg.lerctr.org /usr/local/etc/poudriere.d $ cat p110armv6-make.conf > >> >> CFLAGS += -DCPU_ARM1136=1 > >> >> borg.lerctr.org /usr/local/etc/poudriere.d $ > >> >> > >> >> However, I'm not sure if that's kosher for a port to just define. > >> >> > >> >> Can any of the arm experts help here? > >> >> > >> >> > >> >> > >> > > >> > See if the attached patch helps. The specific type of cpu shouldn't > >> > really matter outside the kernel (or even inside it except in a couple > >> > places), what usually matters is the architecture, which we've > >> > simplified to v4 versus v6 for most purposes. > >> > > >> > The attached patch will use the compiler's predefined values for arch > >> > to > >> > set our old-school symbols, which we really need to do a big cleanup > >> > pass on, but hopefully this little hack will get you going until that > >> > gets done. Let me know if this works and I'll commit it. > >> > > >> > -- Ian > >> Thanks. I'm having a hard time convincing poudriere to apply this > >> patch > >> to the environment > >> > >> Any ideas? > > > > Hrm, I seem to have fumbled the cpuconf.h attachment on the last try. > > > > -- Ian > still get: > --- dproc.o --- > In file included from ./dlsof.h:90: > In file included from /usr/src/sys/sys/conf.h:44: > In file included from /usr/src/sys/sys/eventhandler.h:34: > In file included from /usr/src/sys/sys/mutex.h:40: > In file included from /usr/src/sys/sys/pcpu.h:48: > In file included from /usr/include/machine/pcpu.h:35: > /usr/include/machine/cpuconf.h:180:2: error: ARM_NMMUS is 0 > > so we still need some more help here. > > Urk, there were even more cpu-specific tests were lurking further down in the file. See if this fixes it... -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1419374279.1018.144.camel>