From owner-svn-ports-all@freebsd.org Mon Apr 24 11:12:28 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE2AFD4DF09; Mon, 24 Apr 2017 11:12:28 +0000 (UTC) (envelope-from kwm@FreeBSD.org) Received: from smtpq5.tb.mail.iss.as9143.net (smtpq5.tb.mail.iss.as9143.net [212.54.42.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8F58D16D4; Mon, 24 Apr 2017 11:12:28 +0000 (UTC) (envelope-from kwm@FreeBSD.org) Received: from [212.54.42.116] (helo=lsmtp2.tb.mail.iss.as9143.net) by smtpq5.tb.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1d2bel-00047F-Ke; Mon, 24 Apr 2017 12:55:47 +0200 Received: from f49083.upc-f.chello.nl ([80.56.49.83] helo=[192.168.1.74]) by lsmtp2.tb.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1d2bel-0000CL-GK; Mon, 24 Apr 2017 12:55:47 +0200 Message-ID: <1493031346.1415.7.camel@FreeBSD.org> Subject: Re: svn commit: r439206 - in head: deskutils/xfce4-notifyd games/lordsawar graphics/cairomm graphics/gdk-pixbuf2 graphics/gdk-pixbuf2/files x11-themes/adwaita-icon-theme x11-themes/gnome-themes-standar... From: Koop Mast To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Date: Mon, 24 Apr 2017 12:55:46 +0200 In-Reply-To: References: <201704230835.v3N8ZSLg071205@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SourceIP: 80.56.49.83 X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.2 cv=Se2HTrZu c=1 sm=1 tr=0 a=06UDlCbfTTtHZh+D0N39nQ==:17 a=IkcTkHD0fZMA:10 a=AzvcPWV-tVgA:10 a=6I5d2MoRAAAA:8 a=bHuMgJEcAAAA:8 a=6FQnou8og28Ba9IlT5EA:9 a=QEXdDO2ut3YA:10 a=-FEs8UIgK8oA:10 a=NWVoK91CQyQA:10 a=IjZwj45LgO3ly-622nXo:22 a=ER9dvvqipiF2I_oMOK-d:22 none X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2017 11:12:28 -0000 On Sun, 2017-04-23 at 11:21 +0200, Jan Beich wrote: > Koop Mast writes: > > > > > Author: kwm > > Date: Sun Apr 23 08:35:28 2017 > > New Revision: 439206 > > URL: https://svnweb.freebsd.org/changeset/ports/439206 > > > > Log: > >   Update the gtk+ stack [1] > [...] > > > > Index: x11-themes/gtk-arc-themes/Makefile > > =================================================================== > > --- x11-themes/gtk-arc-themes/Makefile (revision 439205) > > +++ x11-themes/gtk-arc-themes/Makefile (revision 439206) > > @@ -25,5 +25,6 @@ USES= autoreconf pkgconfig > >  GNU_CONFIGURE= yes > >  USE_GNOME= gtk20 gtk30 > >  NO_ARCH= yes > > +CONFIGURE_ARGS= --with-gnome=3.18 > Why not 3.20 after x11-toolkits/gtk30 > 3.18 update? Hi, Because gtk version != gnome version :) It defaults to the latest released gnome version, which we don't have so we need to set our version. > > > > Index: x11-toolkits/gtk30/Makefile > > =================================================================== > > --- x11-toolkits/gtk30/Makefile (revision 439205) > > +++ x11-toolkits/gtk30/Makefile (revision 439206) > > @@ -4,8 +4,8 @@ > >  # adwaita-icon-theme, gnome-themes-standard and mate-themes > > > >  PORTNAME= gtk > > -PORTVERSION= 3.18.8 > > -PORTREVISION?= 4 > > +PORTVERSION= 3.22.12 > 3.20 changed ABI, so you need to bump PORTREVISION in consumers. > > https://abi-laboratory.pro/tracker/timeline/gtk+/ Yes it reports ABI breakage, great site btw. However these removed symbols are all in de gdk_wayland_* space. I assume wayland got removed from the test system.. Anyway, since wayland support wasn't enabled this is not a problem. https://abi-laboratory.pro/tracker/compat_report/gtk+/3.18.9/3.20.0/a91 f6/abi_compat_report.html > > > > @@ -54,7 +56,7 @@ GLIB_SCHEMAS= org.gtk.Demo.gschema.xml \ > >   org.gtk.Se@@ -76,6 +78,8 @@ > > CLOUDPRINT_LIB_DEPENDS= librest-0.7.so:devel/libreema.xml \ > >   org.gtk.Settings.FileChooser.gschema.xml > > > > -OPTIONS_DEFINE= CUPS CLOUD+RINT COLORD DEBUG BROADWAY > > +OPTIONS_DEFINE= CUPS CLOUDPRINT COLORD +ROADWAY > Can you revert this > hunk? After that bump PORTREVISION as BROADWAY is > enabled by default. Conside it done, I will add a little info too, from your commit so I don't accidently change it. Thanks, for your feedback! -Koop