From owner-svn-src-all@freebsd.org Tue Sep 24 19:55:47 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D4B0612F820 for ; Tue, 24 Sep 2019 19:55:47 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46dBkq0prVz3QgS for ; Tue, 24 Sep 2019 19:55:46 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pl1-x642.google.com with SMTP id u12so1404986pls.12 for ; Tue, 24 Sep 2019 12:55:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=skIkN2hDol9WPHEkFBDTKJmrv7MQAHQhhfjcw6rXFvs=; b=qxUUuExFjLnwIhVsRstAig60tYBcAFZzDtq+nXmDGA2iRy8k5YO1Ruxvpb6FLUb83j RKXdm9AICaDjFgF/cbTOAOAUAgMCISmgmOcJSvLiYc+QVAXz6faM6YrYzQP7cu0uNJSW iaL5oFx7NmnCLtExQtWKjgfPviYPMV1oFyVkeEaNgi77GRtl/29y1mDVzxPeMuryEUmP n+nqp3AvUYZ1Wfk+TFPeNLlqyRNUwWIjIsutwKgE5csooHcTnMi4J3ckJ95e6DJaRFK4 u/9jySCM7QmnhlpIozWIYJD3JPnfcvqlVaIRc59uHYG+DHfzAXfn64zPXr/WfbYKqht0 C+1Q== X-Gm-Message-State: APjAAAWnLstM7ZxOAiaEV19DEroiNULpF6dQw23BQvZiUvmm+F4k2rf/ UvCr/AGCebxLcpjmj7yjFWeT7A== X-Google-Smtp-Source: APXvYqyuKsNLn7bNgBUMWUL8Gs2z8Dted8roMs/dGhNugtKu9nyD59w364pKfei1O96E02ChG5NKHw== X-Received: by 2002:a17:902:8ec2:: with SMTP id x2mr4550213plo.250.1569354945503; Tue, 24 Sep 2019 12:55:45 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::eb2d? ([2607:fb10:7021:1::eb2d]) by smtp.gmail.com with ESMTPSA id s3sm715530pjq.32.2019.09.24.12.55.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Sep 2019 12:55:44 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys From: Randall Stewart In-Reply-To: Date: Tue, 24 Sep 2019 12:55:42 -0700 Cc: "O. Hartmann" , Randall Ray Stewart , src-committers , svn-src-all , svn-src-head Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909241818.x8OIIBNr039667@repo.freebsd.org> <20190924212918.01e52920@thor.intern.walstatt.dynvpn.de> To: Li-Wen Hsu X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46dBkq0prVz3QgS X-Spamd-Bar: ------------- X-Spamd-Result: default: False [-13.54 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; RCVD_IN_DNSWL_NONE(0.00)[2.4.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-1.04)[ip: (-0.33), ipnet: 2607:f8b0::/32(-2.63), asn: 15169(-2.19), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Sep 2019 19:55:47 -0000 12.0R would not have BBR .. its only in head=E2=80=A6 hmm it could be a = issue with TCP_RATELIMIT not defined though I did compile GENERIC without the extra stacks (and without rate = limit and hpts) and that compiled ok.. R > On Sep 24, 2019, at 12:49 PM, Li-Wen Hsu wrote: >=20 > On Tue, Sep 24, 2019 at 9:29 PM O. Hartmann = wrote: >>=20 >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA256 >>=20 >> Am Tue, 24 Sep 2019 18:18:11 +0000 (UTC) >> Randall Stewart schrieb: >>=20 >>> Author: rrs >>> Date: Tue Sep 24 18:18:11 2019 >>> New Revision: 352657 >>> URL: https://svnweb.freebsd.org/changeset/base/352657 >=20 > ... >=20 >> This break kernel builds: >>=20 >> [...] >> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:9: = error: implicit >> declaration of function 'tcp_chg_pacing_rate' is invalid in C99 >> [-Werror,-Wimplicit-function-declaration] nrte =3D = tcp_chg_pacing_rate(bbr->r_ctl.crte, ^ >> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:9: = error: this function >> declaration is not a prototype [-Werror,-Wstrict-prototypes] >> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:7: = error: incompatible >> integer to pointer conversion assigning to 'const struct = tcp_hwrate_limit_table *' from 'int' >> [-Werror,-Wint-conversion] nrte =3D = tcp_chg_pacing_rate(bbr->r_ctl.crte, ^ >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- all_subdir_toecore --- = Building >> = /usr/obj/usr/src/amd64.amd64/sys/THOR/modules/usr/src/sys/modules/toecore/= toecore.ko --- >> all_subdir_tcp --- = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:10443:4: >> error: implicit declaration of function 'tcp_rel_pacing_rate' is = invalid in C99 >> [-Werror,-Wimplicit-function-declaration] = tcp_rel_pacing_rate(bbr->r_ctl.crte, bbr->rc_tp); ^ >> - --- all_subdir_tpm --- >> =3D=3D=3D> tpm (all) >> - --- all_subdir_tcp --- >> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:10443:4: = error: this function >> declaration is not a prototype [-Werror,-Wstrict-prototypes] --- = all_subdir_trm --- >> =3D=3D=3D> trm (all) >> - --- all_subdir_tcp --- >> = /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:14307:21: = error: implicit >> declaration of function 'tcp_set_pacing_rate' is invalid in C99 >> [-Werror,-Wimplicit-function-declaration] bbr->r_ctl.crte =3D = tcp_set_pacing_rate(bbr->rc_tp, >=20 > CI completed a clean build on 12.0-R: > https://ci.freebsd.org/job/FreeBSD-head-amd64-build/14672/ >=20 > What's your build environment and platform? >=20 > Best, > Li-Wen ------ Randall Stewart rrs@netflix.com