From owner-freebsd-hackers@FreeBSD.ORG Fri Nov 16 18:18:35 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0CB0D611; Fri, 16 Nov 2012 18:18:35 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx1.freebsd.org (Postfix) with ESMTP id B7B558FC13; Fri, 16 Nov 2012 18:18:34 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id kp6so2176966pab.13 for ; Fri, 16 Nov 2012 10:18:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=nRysIY4X4RfararhPqj5VTqIbtfZCBOY1GFCTBbZ3Dw=; b=FcDn2FmlGFtb+K+5mZHGtACC7Ij9zrmR5cJ4epJc7ie3geFXj1gTQrctK6SZPRb7FB po358bqxbjrxOS+qD7DCVhAjq5bZrtVRfv92sz6SvS63i4A4sqPUaloUhQykQCVpyBOm gua5z3LBGVhntQU14c+AzEj3ia5dw5zLc67EXj6aiDZAbkjbKKUI2FMUZXUq9RooRlm4 tVtpNPqah7MFfS1vJuV4IPL2hZ/Ol/icdzbp8mjUGQVEgXZ8OoOG52aOG0CQpPKvMask B8JDeBNmL9FPFk1ST4USPevkxDcOnEGadl7ENKyJBM1Ykk9oJROJPtlzD1oG2NhKhVdo qdRg== MIME-Version: 1.0 Received: by 10.68.251.197 with SMTP id zm5mr17414616pbc.30.1353089914166; Fri, 16 Nov 2012 10:18:34 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.68.124.130 with HTTP; Fri, 16 Nov 2012 10:18:34 -0800 (PST) In-Reply-To: <50A5F8C1.6010700@mu.org> References: <1353001175.1217.153.camel@revolution.hippie.lan> <1353009310.1217.172.camel@revolution.hippie.lan> <50A555BD.1010105@FreeBSD.org> <50A578A6.1030005@mu.org> <50A5E9B4.5040807@FreeBSD.org> <50A5F8C1.6010700@mu.org> Date: Fri, 16 Nov 2012 10:18:34 -0800 X-Google-Sender-Auth: 4fp_vWprDQa8_kIohSiLQx8kh2k Message-ID: Subject: Re: [RFQ] make witness panic an option From: Adrian Chadd To: Alfred Perlstein Content-Type: text/plain; charset=ISO-8859-1 Cc: attilio@freebsd.org, Ian Lepore , freebsd-arch@freebsd.org, Andriy Gapon , freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2012 18:18:35 -0000 On 16 November 2012 00:26, Alfred Perlstein wrote: > Adding another option to tag asserts so that it was sort of like: > > KASSERT((cond, section, "string")); would be interesting, then you could > turn KASSERTS on based on "vfs" or possibly file by file. That's orthogonal to my developer-focused request. I'm also a big fan of correctly using asserts/panics - ie, asserts shouldn't replace correct error handling. (Yes, I'm guilty of this in ath(4), but I have plans soon to rectify this.) Adrian