From owner-svn-src-all@freebsd.org Tue Jul 16 17:29:43 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 50169B5A55; Tue, 16 Jul 2019 17:29:43 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F17296AF43; Tue, 16 Jul 2019 17:29:41 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pl1-f172.google.com with SMTP id ay6so10457413plb.9; Tue, 16 Jul 2019 10:29:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ILUKmuyGxUPugrs/o1tpBIgPvmnGMoJ+ulG97kAsQXM=; b=TszS6pHGyOVedQXFxmJ9CPxvRxqz38GgmxM4bOuMesFA7FKdBuFIW5MeAxSjjfGXiK JF/YW+hu1gcIwuV+hdA0Ecwpr3XTwZO1X9R3/zrFiFfZw6egkrA3FFaCvS56d7ggvNK3 qEAuNWrhI6LVqoSXu6sizlWYulTh7jGKJ+rOSFU+2DeiiMEijbL6aIWuAfZAn+JFdw5G sMnsLTj60PnFr83vNO48TnIojCQHgMDUN+pCtCKBLlKj4H3d1y7FDrRBESNfYxjVLh1U xQhRy/cyCM38pMpqU0ZBWKa1ztsh8yUIuId9dLWbZWWB1Vh+8AxA1ZP6dMefEoFiPqZm J0AA== X-Gm-Message-State: APjAAAWiMY2QF/u4kQhlViJUG5MSY3tzvYY2jBHc09/ETSWUJTTdlYMf pwWRlFG7eRugeVxU+EgZM/O6XWmC X-Google-Smtp-Source: APXvYqysIop7rmAhcY5ZScsgvJVVtjPehjlZfttfoTYFAcedPBwi6LfhkOmrngZ2OwvVygtSwHsGIQ== X-Received: by 2002:a17:902:2a6b:: with SMTP id i98mr34894775plb.75.1563294488323; Tue, 16 Jul 2019 09:28:08 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-249-80.atc.tvcom.ru. [82.140.249.80]) by smtp.googlemail.com with ESMTPSA id b17sm23939827pgj.73.2019.07.16.09.28.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2019 09:28:07 -0700 (PDT) Subject: Re: svn commit: r350044 - in stable/12: share/man/man4 sys/dev/gpio To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org References: <201907161552.x6GFqlU5013936@repo.freebsd.org> From: Andriy Gapon Openpgp: preference=signencrypt Message-ID: <94d937ee-e121-8882-9859-7d477e18beb4@FreeBSD.org> Date: Tue, 16 Jul 2019 19:28:00 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <201907161552.x6GFqlU5013936@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F17296AF43 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-5.80 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.66)[-0.659,0]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[172.214.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-3.13)[ip: (-9.71), ipnet: 209.85.128.0/17(-3.46), asn: 15169(-2.45), country: US(-0.06)] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 17:29:43 -0000 On 16/07/2019 18:52, Andriy Gapon wrote: > Author: avg > Date: Tue Jul 16 15:52:47 2019 > New Revision: 350044 > URL: https://svnweb.freebsd.org/changeset/base/350044 > > Log: > MFC r349460: gpiobus: provide a new hint, pin_list > > "pin_list" allows to specify child pins as a list of pin numbers. > Existing hint "pins" serves the same purpose but with a 32-bit wide bit > mask. One problem with that is that a controller can have more than 32 > pins. One example is amdgpio. Also, a list of numbers is a little bit > more human friendly than a matching bit mask. As a side note, it seems > that in FDT pins are typically specified by their numbers as well. > > This commit also adds accessors for instance variables (IVARs) that > define the child pins. My primary goal is to allow a child to be > configured programmatically rather than via hints (assuming that FDT is > not supported on a platform). Also, while a child should not care about > specific pin numbers that are allocated to it, it could be interested in > how many were actually assigned to it. > > While there, I removed "flags" instance variable. It was unused. This change (the "flags" removal, specifically) broke build on OFW platforms (powerpc). I am working on a fix, it should be trivial. > Modified: > stable/12/share/man/man4/gpio.4 > stable/12/sys/dev/gpio/gpiobus.c > stable/12/sys/dev/gpio/gpiobusvar.h > Directory Properties: > stable/12/ (props changed) -- Andriy Gapon