Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 May 2015 20:22:06 -0500
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        d@delphij.net, Thomas Quinot <thomas@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r282736 - in head: . lib/libmd
Message-ID:  <555155BE.30604@FreeBSD.org>
In-Reply-To: <55514EFA.4040608@delphij.net>
References:  <201505102121.t4ALLr3A076661@svn.freebsd.org> <5551480E.90906@FreeBSD.org> <55514EFA.4040608@delphij.net>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--5gCrqb4kXNxSgIgNFXDfKv7Ne6135h6FP
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 5/11/2015 7:53 PM, Xin Li wrote:
> On 05/11/15 17:23, Bryan Drewery wrote:
>> The libmd changes break pkg - so all packages.
>=20
>> http://beefy6.nyi.freebsd.org/data/head-amd64-default/p386108_s282785/=

> logs/pkg-1.5.2.log
>=20
>=20
>=20
>>> CCLD     pkg-static /usr/lib/liblzma.a(check.o): In function
>>> `lzma_check_init':=20
>>> /usr/local/poudriere/jails/head-amd64/usr/src/lib/liblzma/../../contr=

> ib/xz/src/liblzma/check/check.c:(.text+0x5e):
>>> undefined reference to `_libmd_SHA256_Init'=20
>>> /usr/lib/liblzma.a(check.o): In function `lzma_check_update':=20
>>> /usr/local/poudriere/jails/head-amd64/usr/src/lib/liblzma/../../contr=

> ib/xz/src/liblzma/check/check.c:(.text+0xbf):
>>> undefined reference to `_libmd_SHA256_Update'=20
>>> /usr/lib/liblzma.a(check.o): In function `lzma_check_finish':=20
>>> /usr/local/poudriere/jails/head-amd64/usr/src/lib/liblzma/../../contr=

> ib/xz/src/liblzma/check/check.c:(.text+0x10d):
>>> undefined reference to `_libmd_SHA256_Final' cc: error: linker
>>> command failed with exit code 1 (use -v to see invocation) ***
>>> [pkg-static] Error code 1
>=20
>=20
>> Can you please just revert this and 282726 until they are working
>> and have a passing exp-run?
>=20
> Looks like this is because my change (r282775) which makes libmd a
> dependency of liblzma, while pkg didn't catch up with, and it's
> unrelated to libmd change.
>=20
> A quick hack would be:
>=20
> --- src/Makefile.in.orig	2015-05-11 17:49:52.690333554 -0700
> +++ src/Makefile.in	2015-05-11 17:50:03.427853585 -0700
> @@ -617,7 +617,7 @@
>  	$(top_builddir)/compat/libbsd_compat.la \
>  	$(top_builddir)/external/libsbuf_static.la $(pkg_OBJECTS) \
>  	@LIBJAIL_LIB@ @LDNS_LIBS@ @OS_LIBS@ -larchive -lz -lutil -lbz2 \
> -	-llzma -lssl -lcrypto -lm $(am__append_1) $(am__append_2) \
> +	-lmd -llzma -lssl -lcrypto -lm $(am__append_1) $(am__append_2) \
>  	$(am__append_3)
>  DYNPROG =3D pkg
>  @BUILD_STATIC_TRUE@pkg_static_LDFLAGS =3D -all-static
>=20
> But it would break earlier FreeBSD.  Should I revert my change and
> request for a exp-run?

Please.

--=20
Regards,
Bryan Drewery


--5gCrqb4kXNxSgIgNFXDfKv7Ne6135h6FP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJVUVW/AAoJEDXXcbtuRpfPXAoIAInPx3TkJ4QxwE23GJx/bitp
YTPOQQI1O3mhYOojDz7WC2gAqIZ1qV7Nk+uwtJMvNTvm02HRdRHMLhWZmDxmcQTd
jabzBTmHReGoAYLinpUOwc6yJdMBDJi+wB0IZFHVZ/alR/taEs1Sy/7RiBdMNFRU
YgPqxUZd4dV/soyddUGwVesXb8vwzc1/YXFK2YdMvWu6hodhocUUvGxq5IFOay85
gxvXGIxhGI04Sa0hzVntchynQaoFoDjAO7agwvltxZ+YV1UzWeUpQ4oPSpSfvZHD
qA/sUIX5uc2w/kDIFPSgU/C7/bEDQM0Tba3gWP5zZS0x16tpomGEx+KdnLwKy9I=
=mFvQ
-----END PGP SIGNATURE-----

--5gCrqb4kXNxSgIgNFXDfKv7Ne6135h6FP--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?555155BE.30604>