From owner-freebsd-commit Mon Nov 6 08:13:38 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id IAA00303 for freebsd-commit-outgoing; Mon, 6 Nov 1995 08:13:38 -0800 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id IAA00291 for cvs-all-outgoing; Mon, 6 Nov 1995 08:13:34 -0800 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id IAA00280 for cvs-sys-outgoing; Mon, 6 Nov 1995 08:13:29 -0800 Received: from jhome.DIALix.COM (root@jhome.DIALix.COM [192.203.228.69]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id IAA00272 ; Mon, 6 Nov 1995 08:13:13 -0800 Received: (from peter@localhost) by jhome.DIALix.COM (8.6.12/8.6.9) id AAA07056; Tue, 7 Nov 1995 00:12:58 +0800 Date: Tue, 7 Nov 1995 00:12:57 +0800 (WST) From: Peter Wemm To: Bruce Evans cc: dyson@freefall.freebsd.org, j@uriah.heep.sax.de, CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_lookup.c In-Reply-To: <199511061550.CAA22468@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-commit@FreeBSD.org Precedence: bulk On Tue, 7 Nov 1995, Bruce Evans wrote: > >> Modified: sys/ufs/ufs ufs_lookup.c > >> Log: > >> This commit causes UFS to perform at Linux EXT2FS metadata rates. > >> ... Just use the -o async flag on the > >> UFS mount. Good luck... > > >Great! > > >I will stress-test this on my /tmp partition! > > I think the MNT_ASYNC check in ffs_update() goes too far. It stops > timestamps (and perhaps more important things) from being written > immediately even for sync() and fsync(). > > Bruce Hmm. When I was looking over it, I was wondering if it was going to affect things like sync-on-unmount? Also, it seems to hit the open("file", ... | O_SYNC) as well. Perhaps VOP_UPDATE needs to have it's fourth arg changed from a boolean to an enumeration? 0 = dontwait, 1 = sync_unless_MNT_ASYNC, 2 = sync_I_MEAN_IT (you get the idea.. :-) Cheers, -Peter