From owner-cvs-all@FreeBSD.ORG  Mon Jun 12 15:54:05 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9AF9A16A418;
	Mon, 12 Jun 2006 15:54:05 +0000 (UTC) (envelope-from flz@FreeBSD.org)
Received: from smtp.xbsd.org (xbsd.org [82.233.2.192])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1659443D49;
	Mon, 12 Jun 2006 15:54:05 +0000 (GMT) (envelope-from flz@FreeBSD.org)
Received: from localhost (localhost.xbsd.org [127.0.0.1])
	by smtp.xbsd.org (Postfix) with ESMTP id F36CD11A9E;
	Mon, 12 Jun 2006 17:54:03 +0200 (CEST)
Received: from smtp.xbsd.org ([127.0.0.1])
	by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new,
	port 10024) with ESMTP
	id 01150-06; Mon, 12 Jun 2006 17:53:58 +0200 (CEST)
Received: from mayday.esat.net (mayday.esat.net [193.95.134.156])
	by smtp.xbsd.org (Postfix) with ESMTP id E9E6911411;
	Mon, 12 Jun 2006 17:53:57 +0200 (CEST)
From: Florent Thoumie <flz@FreeBSD.org>
To: Erwin Lansing <erwin@FreeBSD.org>
In-Reply-To: <200606121546.k5CFkhb0078404@repoman.freebsd.org>
References: <200606121546.k5CFkhb0078404@repoman.freebsd.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-10e3eLNG+mabqnjkclB4"
Date: Mon, 12 Jun 2006 16:53:55 +0100
Message-Id: <1150127635.17424.12.camel@mayday.esat.net>
Mime-Version: 1.0
X-Mailer: Evolution 2.6.2 FreeBSD GNOME Team Port 
X-Virus-Scanned: amavisd-new at xbsd.org
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports UPDATING ports/editors/staroffice60 Makefile
	ports/editors/staroffice70 Makefile ports/german/staroffice70
	Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jun 2006 15:54:05 -0000


--=-10e3eLNG+mabqnjkclB4
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 2006-06-12 at 15:46 +0000, Erwin Lansing wrote:
> erwin       2006-06-12 15:46:43 UTC
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     .                    UPDATING=20
>     editors/staroffice60 Makefile=20
>     editors/staroffice70 Makefile=20
>     german/staroffice70  Makefile=20
>   Log:
>   Rename the USE_CDROM knob to WITH_CDROM. USE_* should only be
>   defined by the ports infrastructure and ports should define WITH_*

I would have said: "[...] and ports check for WITH_* user-variables".
You definitely don't want ports to define WITH_* variables.

--=20
Florent Thoumie
flz@FreeBSD.org
FreeBSD Committer

--=-10e3eLNG+mabqnjkclB4
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (FreeBSD)

iD8DBQBEjY4TMxEkbVFH3PQRAp0eAJ95a2txwwVKJBpP6PvMby6KV7uBKwCfcTNe
XAzTmV7RVLFR9hbxl+NZLF0=
=LpJI
-----END PGP SIGNATURE-----

--=-10e3eLNG+mabqnjkclB4--