Date: Tue, 9 Apr 2019 09:11:53 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Ganbold Tsagaankhuu <ganbold@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346052 - head/sys/dev/usb/net Message-ID: <ea3cb1dd-585b-e60f-294a-743645492d69@FreeBSD.org> In-Reply-To: <201904091354.x39Ds9e6070857@repo.freebsd.org> References: <201904091354.x39Ds9e6070857@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/9/19 6:54 AM, Ganbold Tsagaankhuu wrote: > Author: ganbold > Date: Tue Apr 9 13:54:08 2019 > New Revision: 346052 > URL: https://svnweb.freebsd.org/changeset/base/346052 > > Log: > In some cases like NanoPI R1, its second USB ethernet > RTL8152 (chip version URE_CHIP_VER_4C10) doesn't > have hardwired MAC address, in other words, it is all zeros. > This commit fixes it by setting random MAC address > when MAC address is all zeros. > > Reviewed by: kevlo > Differential Revision: https://reviews.freebsd.org/D19856 It would be best to not use a purely random mac address and to use the function kevans@ added recently. That function generates a MAC address from the FreeBSD OUI using a cryptographic hash so you get a stable address across boots on a given host. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ea3cb1dd-585b-e60f-294a-743645492d69>