From owner-cvs-src@FreeBSD.ORG Tue Mar 16 14:00:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D968016A4D0 for ; Tue, 16 Mar 2004 14:00:35 -0800 (PST) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B56443D45 for ; Tue, 16 Mar 2004 14:00:35 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 10589 invoked from network); 16 Mar 2004 22:00:34 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 16 Mar 2004 22:00:34 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i2GM0T28066779; Tue, 16 Mar 2004 17:00:30 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: "M. Warner Losh" Date: Tue, 16 Mar 2004 16:50:23 -0500 User-Agent: KMail/1.6 References: <20040316.224458.21308983.non@ever.sanda.gr.jp> <20040316125222.G96418@root.org> <20040317.045645.83723898.imp@bsdimp.com> In-Reply-To: <20040317.045645.83723898.imp@bsdimp.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200403161650.23938.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx X-Mailman-Approved-At: Wed, 17 Mar 2004 04:58:08 -0800 cc: src-committers@FreeBSD.org cc: non@ever.sanda.gr.jp cc: peter@FreeBSD.org cc: cvs-src@FreeBSD.org cc: obrien@FreeBSD.org cc: cvs-all@FreeBSD.org cc: nate@root.org cc: nyan@jp.FreeBSD.org cc: peter@wemm.org Subject: Re: cvs commit: src/sys/i386/include dvcfg.h physio_proc.h src/sys/amd64/include dvcfg.h physio_proc.h src/sys/compat/netbsd dvcfg.h physio_proc.h src/sys/dev/ct bshw_machdep.c ct.c ct_isa.c src/sys/d X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2004 22:00:36 -0000 On Tuesday 16 March 2004 03:56 pm, M. Warner Losh wrote: > In message: <20040316125222.G96418@root.org> > > Nate Lawson writes: > : On Tue, 16 Mar 2004, M. Warner Losh wrote: > : > In message: <20040316.224458.21308983.non@ever.sanda.gr.jp> > : > > : > non@ever.sanda.gr.jp writes: > : > : From: Takahashi Yoshihiro > : > : Date: Tue, 16 Mar 2004 21:14:53 +0900 (JST) > : > : > : > : > In article <200403150741.38591.peter@wemm.org> > : > : > > : > : > Peter Wemm writes: > : > : > > I don't really care where they go, as long as it isn't in the MD > : > : > > include areas (they are not MD!), and not in sys/. My favorites > : > : > > right now are dev/pc98/* or compat/pc98/*. I would also like > : > : > > sys/device_port.h to move there too since it is used by the same > : > : > > group of ct/ncv/nsp/stg drivers. > : > : > > : > : > I repeat that they have NO relations with pc98. So, the above > : > : > proposals are not acceptable. > : > : > : > : I agree with nyan-san. They are not specific to pc98 not for > : > : compatibility. I think they should be in sys/ or dev/dev/* or > : > : somewhere MI and not in compat/* . > : > > : > dev/pc98 isn't right. I have pcmcia cards that are supported by the > : > ncv, nsp and stg drivers running on an i386 box. dev/sys is fine by > : > me too if you are looking for a name. > : > : Blech, did you see the suggestion for /src/sys/dev/ic/ ? > > Yes. I saw that since I made it. > > I like dev/include, but maybe a more fundamental question is that > these are a portability layer shared between a number of differen > systems, does that layer have a name? Does it even need to exist? dvcfg seems to provide an array of softc's, something we tried to kill in new-bus. physio_proc() doesn't do anything at all. Is there a reason we use these APIs rather than just chucking the physio_proc() one and replacing dvcfg() with sane use of device_get_softc() and dev->si_drv1 instead? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org