Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 8 Mar 2016 00:09:34 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r296474 - in head/lib/libc: amd64/sys i386/sys
Message-ID:  <201603080009.u2809YBr029821@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Tue Mar  8 00:09:34 2016
New Revision: 296474
URL: https://svnweb.freebsd.org/changeset/base/296474

Log:
  libc/{i386,amd64}: Do not export .cerror when building WITHOUT_SYMVER
  
  Further to r240152 (i386) and r240178 (amd64), hide the .cerror symbol
  so that it is not exported if symbol versioning is not in use.  Without
  this change WITHOUT_SYMVER libc contains .text relocations for .cerror,
  as described in LLVM PR 26813 (http://llvm.org/pr26813).
  
  This is a no-op for the regular build as the symbol version script
  already controls .cerror visibility.
  
  PR:		207712
  Submitted by:	Rafael EspĂ­ndola
  Reviewed by:	jilles, kib
  Differential Revision:	https://reviews.freebsd.org/D5571

Modified:
  head/lib/libc/amd64/sys/cerror.S
  head/lib/libc/i386/sys/cerror.S

Modified: head/lib/libc/amd64/sys/cerror.S
==============================================================================
--- head/lib/libc/amd64/sys/cerror.S	Mon Mar  7 21:45:24 2016	(r296473)
+++ head/lib/libc/amd64/sys/cerror.S	Tue Mar  8 00:09:34 2016	(r296474)
@@ -39,6 +39,7 @@ __FBSDID("$FreeBSD$");
 #include "SYS.h"
 
 	.globl HIDENAME(cerror)
+	.hidden HIDENAME(cerror)
 
 	/*
 	 * The __error() function is thread aware. For non-threaded

Modified: head/lib/libc/i386/sys/cerror.S
==============================================================================
--- head/lib/libc/i386/sys/cerror.S	Mon Mar  7 21:45:24 2016	(r296473)
+++ head/lib/libc/i386/sys/cerror.S	Tue Mar  8 00:09:34 2016	(r296474)
@@ -39,6 +39,7 @@ __FBSDID("$FreeBSD$");
 #include "SYS.h"
 
 	.globl HIDENAME(cerror)
+	.hidden HIDENAME(cerror)
 
 	/*
 	 * The __error() function is thread aware. For non-threaded



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201603080009.u2809YBr029821>