From owner-freebsd-current Fri Jun 22 10:31:59 2001 Delivered-To: freebsd-current@freebsd.org Received: from technokratis.com (modemcable052.174-202-24.mtl.mc.videotron.ca [24.202.174.52]) by hub.freebsd.org (Postfix) with ESMTP id B446637B401; Fri, 22 Jun 2001 10:31:56 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: (from bmilekic@localhost) by technokratis.com (8.11.3/8.11.3) id f5MHWLs02634; Fri, 22 Jun 2001 13:32:21 -0400 (EDT) (envelope-from bmilekic) Date: Fri, 22 Jun 2001 13:32:21 -0400 From: Bosko Milekic To: John Baldwin Cc: Alfred Perlstein , freebsd-current@FreeBSD.org, "Alexander N. Kabaev" Subject: Re: [HEADS-UP]: Mbuf allocator changes Message-ID: <20010622133221.A2616@technokratis.com> References: <20010622121725.X4543@sneakerz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Fri, Jun 22, 2001 at 10:35:32AM -0700 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Jun 22, 2001 at 10:35:32AM -0700, John Baldwin wrote: > > On 22-Jun-01 Alfred Perlstein wrote: > > * Alexander N. Kabaev [010622 10:46] wrote: > >> UP kernel can not be compiled in -CURRENT after your changes because > >> kern/subr_mbuf.c references mp_ncpus variable, which is defined only in SMP > >> case. Should this variable be moved out of #ifdef SMP? > > > > Yes, I asked for this months ago, I thought it was already done. > > mp_npcus is not initialized, etc. in the UP case. I suppose it could be > statically initialized to 1 and moved, but in that case it needs renaming, as > mp_ncpus implies SMP (mp_ prefix). If you want to make it ncpus and move it to > sys/systm.h and stick it somewhere MI initialized to 1 that is fine. Then > hw.ncpus can reference that (well, it's called hw.ncpu right now, perhaps it > should be renamed to match the variable *shrug*) and kern.smp.cpus can die as > it won't be needed any longer. Note that we already have a (machdep, I think) sysctl exported ncpu variable. > > -Alfred > > -- > > John Baldwin -- http://www.FreeBSD.org/~jhb/ > PGP Key: http://www.baldwin.cx/~john/pgpkey.asc > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > -- Bosko Milekic bmilekic@technokratis.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message