From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Dec 21 18:40:07 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78FDF1065672 for ; Wed, 21 Dec 2011 18:40:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5497B8FC15 for ; Wed, 21 Dec 2011 18:40:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBLIe78x083342 for ; Wed, 21 Dec 2011 18:40:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBLIe73h083341; Wed, 21 Dec 2011 18:40:07 GMT (envelope-from gnats) Resent-Date: Wed, 21 Dec 2011 18:40:07 GMT Resent-Message-Id: <201112211840.pBLIe73h083341@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "A.J. Kehoe IV (Nanoman)" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90E2C106564A for ; Wed, 21 Dec 2011 18:39:32 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 659C68FC12 for ; Wed, 21 Dec 2011 18:39:32 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBLIdWWT096538 for ; Wed, 21 Dec 2011 18:39:32 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pBLIdWWW096537; Wed, 21 Dec 2011 18:39:32 GMT (envelope-from nobody) Message-Id: <201112211839.pBLIdWWW096537@red.freebsd.org> Date: Wed, 21 Dec 2011 18:39:32 GMT From: "A.J. Kehoe IV (Nanoman)" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/163510: FreeBSD Port emulators/fceux Patch X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2011 18:40:07 -0000 >Number: 163510 >Category: ports >Synopsis: FreeBSD Port emulators/fceux Patch >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Dec 21 18:40:06 UTC 2011 >Closed-Date: >Last-Modified: >Originator: A.J. Kehoe IV (Nanoman) >Release: 8.2 >Organization: Nanoman's Company >Environment: FreeBSD localhost 8.2-RELEASE-p3 FreeBSD 8.2-RELEASE-p3 #0: Tue Sep 27 18:07:27 UTC 2011 root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: The maintainer (davide.italiano@gmail.com) asked me to send a PR because he doesn't have time for this at the moment. I discovered that the FreeBSD port emulators/fceux doesn't reinstall as intended. -----BEGIN QUOTE----- # make deinstall ===> Deinstalling for emulators/fceux ===> Deinstalling fceux-2.1.4a # make reinstall ===> Installing for fceux-2.1.4a ===> fceux-2.1.4a depends on shared library: SDL-1.2.11 - found ===> fceux-2.1.4a depends on shared library: lua-5.1.1 - found ===> Generating temporary packing list ===> Checking if emulators/fceux already installed install -s -o root -g wheel -m 555 /usr/ports/emulators/fceux/work/fceu2.1.4a/src/fceux /usr/local/bin install -o root -g wheel -m 444 /usr/ports/emulators/fceux/work/fceu2.1.4a/documentation/fceux.6 /usr/local/man/man6 install: /usr/ports/emulators/fceux/work/fceu2.1.4a/documentation/fceux.6: No such file or directory *** Error code 71 Stop in /usr/ports/emulators/fceux. *** Error code 1 Stop in /usr/ports/emulators/fceux. -----END QUOTE----- >How-To-Repeat: cd /usr/ports/emulators/fceux make install make deinstall make reinstall >Fix: In the "do-install" part of the Makefile, fceux.6 is deleted from the work directory's "documentation" folder. Simply removing this "rm" line would break the package list, so I decided to move fceux.6 out of the work directory's "documentation" folder during the "post-extract" phase. I also noticed that the "post-extract" part of the Makefile doesn't work as intended. The first line starts with spaces instead of a tab, which isn't accepted. I've attached a patch for the Makefile. Patch attached with submission follows: --- ports/emulators/fceux/Makefile.old 2010-09-13 04:42:33.000000000 -0400 +++ ports/emulators/fceux/Makefile 2011-12-21 01:58:32.856832000 -0500 @@ -29,13 +29,13 @@ .include post-extract: - ${REINPLACE_CMD} -e 's/[[:cntrl:]]*$$//' \ + ${REINPLACE_CMD} -e 's/[[:cntrl:]]*$$//' \ ${WRKSRC}/src/drivers/common/vidblit.cpp + @${MV} ${WRKSRC}/documentation/fceux.6 ${WRKSRC}/ do-install: ${INSTALL_PROGRAM} ${WRKSRC}/src/fceux ${PREFIX}/bin - ${INSTALL_MAN} ${WRKSRC}/documentation/fceux.6 ${PREFIX}/man/man6 - ${RM} ${WRKSRC}/documentation/fceux.6 + ${INSTALL_MAN} ${WRKSRC}/fceux.6 ${PREFIX}/man/man6 .if !defined(NOPORTDOCS) @${MKDIR} ${DOCSDIR} cd ${WRKSRC}/documentation && ${COPYTREE_SHARE} . ${DOCSDIR}/ >Release-Note: >Audit-Trail: >Unformatted: