From owner-freebsd-ports@FreeBSD.ORG  Fri Jul  1 21:25:09 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E893106564A;
	Fri,  1 Jul 2011 21:25:09 +0000 (UTC)
	(envelope-from oliver.pntr@gmail.com)
Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com
	[74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id DFC818FC0C;
	Fri,  1 Jul 2011 21:25:08 +0000 (UTC)
Received: by wyg24 with SMTP id 24so3390167wyg.13
	for <multiple recipients>; Fri, 01 Jul 2011 14:25:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=oCTqIcwXJnmImzu6bWPNYpAdwbAVX3XnnKTxtNbMlSM=;
	b=goyDtlfewi73Eqg9RtAAJ1dJC9VNFDVOtq8mamPBh3GuckVKR9Yu/mibqtRD3OKa+L
	nFv8h7tCwlXJxgJP2f9E6SDY18o/BVxtOFOYy467FcO4VIZmVkGPxiRQ6Dt2AdGAmIQL
	NZOZwn45ZYhrdQW/bIHDMh2x2MCqvWX444kw8=
MIME-Version: 1.0
Received: by 10.227.177.193 with SMTP id bj1mr3442814wbb.30.1309555506747;
	Fri, 01 Jul 2011 14:25:06 -0700 (PDT)
Received: by 10.227.209.209 with HTTP; Fri, 1 Jul 2011 14:25:06 -0700 (PDT)
In-Reply-To: <4E0E1937.8040808@freebsd.org>
References: <BANLkTikbaBVbLoU47YECC=hjN+aunoeURw@mail.gmail.com>
	<BANLkTim8ZdMqrYkhLAzm_QjsTtQFUU-3MA@mail.gmail.com>
	<BANLkTi=b=0hHbWYcEBrZH8Jw8J99+=jzbQ@mail.gmail.com>
	<4E0E1937.8040808@freebsd.org>
Date: Fri, 1 Jul 2011 23:25:06 +0200
Message-ID: <BANLkTik_RW2TYc9QbqABg88Z3MBRDuy+hw@mail.gmail.com>
From: Oliver Pinter <oliver.pntr@gmail.com>
To: Rene Ladan <rene@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: avilla@freebsd.org, ports@freebsd.org
Subject: Re: failed bsd.qt.mk fix...
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jul 2011 21:25:09 -0000

The original (commited patch in ports) is not my patch. I only wrote a
fixup to make it usable, after avillas commit breaked the ports.

On 7/1/11, Rene Ladan <rene@freebsd.org> wrote:
> Op 01-07-2011 20:54, Oliver Pinter schreef:
>> On 7/1/11, Oliver Pinter <oliver.pntr@gmail.com> wrote:
>>> after reverting this:
>>> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.qt.mk.diff?r1=1.24;r2=1.25
>>> everything look fine..
>>
>> or use this patch:
>>
>> op@pandora-d ~> less /tmp/diff
>> --- bsd.qt.mk   2011-07-01 20:53:32.000000000 +0200
>> +++ bsd.qt.mk-op        2011-07-01 20:52:48.000000000 +0200
>> @@ -112,7 +112,7 @@
>>  #
>>  # Translate `c++` to its real name and select the appropriate mkspec.
>>  #
>> -QMAKE_BASE_COMPILER!=  cc --version 2> /dev/null | awk 'NR == 1 {
>> gsub(/[()]/, "", $2); print $2 }'
>> +QMAKE_BASE_COMPILER!=  cc --version 2> /dev/null | awk 'NR == 1 {
>> gsub(/[()]/, "", $$2); print $$2 }'
>>  .if ${QMAKE_BASE_COMPILER:L} == "gcc"
>>  QMAKE_BASE_COMPILER=   g++
>>  .endif
>
> Wouldn't it be better to use ${CC} instead of cc in the above patch so
> that clang is also (a bit more) supported?
> --
> http://www.rene-ladan.nl:8080/
>
> GPG fingerprint = ADBC ECCD EB5F A6B4 549F  600D 8C9E 647A E564 2BFC
> (subkeys.pgp.net)
>

The original (commited patch in ports) is not my patch. I only wrote a
fixup to make it usable, after avillas commit breaked the ports.