From owner-freebsd-current Tue Nov 26 7:35:29 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0860B37B401; Tue, 26 Nov 2002 07:35:28 -0800 (PST) Received: from mailout03.sul.t-online.com (mailout03.sul.t-online.com [194.25.134.81]) by mx1.FreeBSD.org (Postfix) with ESMTP id E438743EAF; Tue, 26 Nov 2002 07:35:21 -0800 (PST) (envelope-from garyj@jennejohn.org) Received: from fwd03.sul.t-online.de by mailout03.sul.t-online.com with smtp id 18Ghk9-00012U-00; Tue, 26 Nov 2002 16:35:21 +0100 Received: from peedub.jennejohn.org (520017439985-0001@[217.235.115.206]) by fmrl03.sul.t-online.com with esmtp id 18Ghj8-1XP92uC; Tue, 26 Nov 2002 16:34:18 +0100 Received: from peedub.jennejohn.org (localhost [127.0.0.1]) by peedub.jennejohn.org (8.12.6/8.11.6) with ESMTP id gAQFXwXA012323; Tue, 26 Nov 2002 16:34:03 +0100 (CET) (envelope-from garyj@peedub.jennejohn.org) Message-Id: <200211261534.gAQFXwXA012323@peedub.jennejohn.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.3 To: dheeraj@ece.gatech.edu Cc: ataraxia@cox.net, jstocker@tzi.de, freebsd-current@freebsd.org, cg@freebsd.org Subject: Re: Kernel broken Reply-To: Gary Jennejohn In-reply-to: Your message of "Tue, 26 Nov 2002 09:38:12 EST." <1038321492.c7af40c0dhee@myrealbox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 26 Nov 2002 16:33:58 +0100 From: Gary Jennejohn X-Sender: 520017439985-0001@t-dialin.net Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > -----Original Message----- > From: Ray Kohler > To: Jan Stocker > Date: Tue, 26 Nov 2002 07:12:37 -0500 > Subject: Re: Kernel broken > > On Tue, Nov 26, 2002 at 12:53:39PM +0100, Jan Stocker wrote: > > CVSuped (2 mins ago) -current kernel is broken: > >=20 > > cc1: warnings being treated as errors > > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_lock': > > /usr/src/sys/dev/sound/isa/ad1816.c:81: warning: dereferencing `void *' > > pointer > > /usr/src/sys/dev/sound/isa/ad1816.c:81: request for member `mtx_lock' in > > something not a structure or union > > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_unlock': > > /usr/src/sys/dev/sound/isa/ad1816.c:87: warning: dereferencing `void *' > > pointer > > /usr/src/sys/dev/sound/isa/ad1816.c:87: request for member `mtx_lock' in > > something not a structure or union > This turns out to be semi-reproduceable. I have this problem but the > committer who made the change can't reproduce it. > I have the same problem, and I've deleted my /usr/src and checked it out new. I've also cvsup'd from 2 different servers - no help. Either the commit never made it from the repository to the servers or something else is totally fubar. The culprit seems to be a change in /sys/dev/sound/pcm/sound.h, where snd_mtx{un}lock() were changed from routines to macros which simply use mtx_{un}lock(). The routines required a ``void *'', but the macros require a ``struct mtx *''. The following drivers still declare the lock to be a ``void *'', which is totally bogus after the above mentioned change: /sys/dev/sound/isa/ad1816.c /sys/dev/sound/isa/mss.c /sys/dev/sound/isa/sbc.c /sys/dev/sound/pci/cmi.c /sys/dev/sound/pci/ds1.c /sys/dev/sound/pci/emu10k1.c /sys/dev/sound/pci/t4dwave.c /sys/dev/sound/pcm/ac97.c /sys/dev/sound/pcm/mixer.c /sys/dev/sound/pcm/sound.c Changing the ``void *'' to ``struct mtx *'' allows the kernel to be compiled and sound also works. This is definitely a show-stopper and should be fixed ASAP, no matter which change is correct. cg is the last committer who touched the header. --- Gary Jennejohn / garyj@jennejohn.org gj@freebsd.org gj@denx.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message