From owner-cvs-all Tue Feb 6 9:16: 8 2001 Delivered-To: cvs-all@freebsd.org Received: from mobile.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147]) by hub.freebsd.org (Postfix) with ESMTP id 6C97137B503; Tue, 6 Feb 2001 09:15:43 -0800 (PST) Received: from netplex.com.au (localhost [127.0.0.1]) by mobile.wemm.org (8.11.1/8.11.1) with ESMTP id f16HFUt49067; Tue, 6 Feb 2001 09:15:30 -0800 (PST) (envelope-from peter@netplex.com.au) Message-Id: <200102061715.f16HFUt49067@mobile.wemm.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Poul-Henning Kamp Cc: Garrett Wollman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/awi awi.c src/sys/dev/ed if_ed.c src/sys/dev/fe if_fe.c src/sys/dev/ie if_ie.c src/sys/dev/lnc if_lnc.c src/sys/dev/pdq pdq_ifsubr.c src/sys/dev/ray if_ray.c src/sys/dev/sn if_sn.c src/sys/dev/snc dp83932.c src/sys/dev/usb ... In-Reply-To: <35709.981479381@critter> Date: Tue, 06 Feb 2001 09:15:30 -0800 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Poul-Henning Kamp wrote: > In message <200102061706.f16H6Ct48905@mobile.wemm.org>, Peter Wemm writes: > > > >> There is no LIST_PREV macro in any versions of the file I know off. > >> > >> See previous email to Peter why making one would be awkward. > > > >Depends on what you want to do. Traversing a list from the end backwards > >is not the only reason for having it. NFS wants it, for example. > > Unless there is a major cost associated with the extra pointer in the > TAILQ_HEAD compared to LIST_HEAD, you should convert it to use TAILQ > then. Actually, what it seems to be doing is testing to see *if* there is a previous node, not what it is. I do not recall why it does this off the top of my head but it shouldn't take long. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message