Date: Wed, 1 Sep 2010 09:46:18 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212064 - head/sys/boot/pc98/boot2 Message-ID: <20100901064618.GE2396@deviant.kiev.zoral.com.ua> In-Reply-To: <4C7D7151.7070001@FreeBSD.org> References: <201008311811.o7VIBoC5037894@svn.freebsd.org> <20100831195128.GC2396@deviant.kiev.zoral.com.ua> <4C7D61E3.6020409@FreeBSD.org> <20100831203358.GD2396@deviant.kiev.zoral.com.ua> <4C7D7151.7070001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0gFGHS8Pm/ryTu+B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 31, 2010 at 11:17:05PM +0200, Dimitry Andric wrote: > Indeed, any subtraction is only in "u_char *p =3D (u_char *)PTOV(0);". If > you prefer, I will revert to the old expression, or maybe we could use > John's suggestion of: >=20 > return (*(u_char *)PTOV(0x401) * 128 * 1024 + > *(uint16_t *)PTOV(0x594) * 1024 * 1024); >=20 > which is less obfuscated. John suggestion looks best, and it makes code cleaner too. --0gFGHS8Pm/ryTu+B Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkx99rkACgkQC3+MBN1Mb4hZegCfTUNbPV6UVQo1X2914eYI3NiK kcUAoOz+TSKZKrF9iKrBpb2gNPe1wuiL =/Dlr -----END PGP SIGNATURE----- --0gFGHS8Pm/ryTu+B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100901064618.GE2396>