Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Feb 2015 23:30:46 -0500
From:      Ryan Stone <rysto32@gmail.com>
To:        Ryan Stone <rstone@freebsd.org>
Cc:        svn-src-stable@freebsd.org, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r279471 - stable/10/sys/dev/pci
Message-ID:  <CAFMmRNz6c2gc%2B-iC4GVSX0kag2JZVG2RfTO5JEZWyABgqHwC7Q@mail.gmail.com>
In-Reply-To: <201503010426.t214Qm0d000607@svn.freebsd.org>
References:  <201503010426.t214Qm0d000607@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 28, 2015 at 11:26 PM, Ryan Stone <rstone@freebsd.org> wrote:
> Author: rstone
> Date: Sun Mar  1 04:26:47 2015
> New Revision: 279471
> URL: https://svnweb.freebsd.org/changeset/base/279471
>
> Log:
>   MFC r264091
>
>      Correct a PCI enumeration bug introduced in r264011
>
>      Ensure that first_func is set to 0 on every iteration of the PCI slot
>      enumeration loop after the first.  There is a continue statement that would
>      cause first_func to stay at 1 any PCI device where slot 0 has no functions
>      until we find a slot that does have a function.  This would cause us to
>      not enumerate the first PCI function on the device.
>
>      Credit to markj@ for spotting the bug.
>
>      X-MFC-With: r264011

So I didn't get an MFC notice for this one (and I very nearly forgot
to MFC it, which would have been fairly disastrous for somebody :( ).
Is my understanding of the X-MFC-With: tag incorrect?  I thought that
setting it would cause me to get a reminder at the same time as
r264011



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFMmRNz6c2gc%2B-iC4GVSX0kag2JZVG2RfTO5JEZWyABgqHwC7Q>