Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 May 1996 23:08:55 +0200 (MET DST)
From:      Wilko Bulte <wilko@yedi.iaf.nl>
To:        freebsd-scsi@freebsd.org (FreeBSD SCSI hackers)
Subject:   removing 32 kbyte limit from dump
Message-ID:  <199605292108.XAA11686@yedi.iaf.nl>

next in thread | raw e-mail | index | archive | help
Hi there

We seem to have agreed that the 32 kbyte limit should be removed from
'dump' and be replaced with the 64 kbyte limit as imposed by physio.
There is a patch below that does just that.

But I'm not really satisfied by this. I'd rather see that the st.c
driver returns EINVAL or something like that when an attempt is made
to write an impossible block size (and of course dump should act 
accordingly when it receives the error value).

Am I missing something here? Did not study dump too carefully, but 
we are now limiting people to <= 64 kbytes even if the output file is
not a tape device. That is not too dramatic, but not clean either..

Anyway, here is the patch to be commited..

Wilko
---------

*** main.c.orig	Wed May 29 22:57:52 1996
--- main.c	Wed May 29 23:01:15 1996
***************
*** 167,177 ****
  		case 'b':		/* blocks per tape write */
  			ntrec = numarg('b', "number of blocks per write",
  			    1L, 1000L, &argc, &argv);
! 			/* XXX restore is unable to restore dumps that 
! 			   were created  with a blocksize larger than 32K.
! 			   Possibly a bug in the scsi tape driver. */
! 			if ( ntrec > 32 ) {
! 				msg("please choose a blocksize <= 32\n");
  				exit(X_ABORT);
  			}
  			break;
--- 167,177 ----
  		case 'b':		/* blocks per tape write */
  			ntrec = numarg('b', "number of blocks per write",
  			    1L, 1000L, &argc, &argv);
! 			/* XXX physio() is currently unable > 64 kByte I/Os */
! 			/* so lets tell the user now and not wait for him/her 
! 			/* to see the console message */
! 			if ( ntrec > 64 ) {
! 				msg("Please choose a blocksize <= 64 \n");
  				exit(X_ABORT);
  			}
  			break;
_     __________________________________________________________________________
 |   / o / /  _   Wilko Bulte             email: wilko@yedi.iaf.nl
 |/|/ / / /( (_)  Private FreeBSD site  - Arnhem - The Netherlands
--------------------------------------------------------------------------------



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199605292108.XAA11686>