Date: Mon, 14 Sep 2009 12:21:33 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-fs@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: Review request for NFS readdirplus change. Message-ID: <Pine.GSO.4.63.0909141218340.19469@muncher.cs.uoguelph.ca> In-Reply-To: <200909140832.27956.jhb@freebsd.org> References: <20090913202350.GE2091@garage.freebsd.pl> <200909140832.27956.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 14 Sep 2009, John Baldwin wrote: > On Sunday 13 September 2009 4:23:50 pm Pawel Jakub Dawidek wrote: >> Hi. >> >> I'm looking for a review of the following patch: >> >> http://people.freebsd.org/~pjd/patches/nfs_serv.c.3.patch >> [good stuff snipped] > > I don't think you need the trailing '\' before a split expression when > building cn_flags. Other than that I think it looks ok from what I can see > (but I am far less familiar with the NFS server than the NFS client). Also, > you might want to patch the new NFS server as well as the old one (or ask > Rick about the new one). > Looks fine to me, too (although I'm not particularily familiar with the flags for VOP_LOOKUP()). I can do a similar change to the experimental server once it goes in. rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.63.0909141218340.19469>