From owner-svn-src-head@freebsd.org Wed Dec 27 22:01:45 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D0AAE80A6C for ; Wed, 27 Dec 2017 22:01:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D931C7A499 for ; Wed, 27 Dec 2017 22:01:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x234.google.com with SMTP id b5so26412081itc.3 for ; Wed, 27 Dec 2017 14:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=noTFGAOjDjJhQHG2H3UQEPhUmxSGntXisFmxZzKD0D0=; b=VXdxEN1qvNAPISBsM/3Vl9HBvW/oyf3ha+YswiFzVm6BY4E3cAuCNRGccbTbiukrxP gAyBFYJ9uzvBHxGixETOd+tcWZWBYM3C3hfeLepAq9wzzbtCrjccTrEMAKtNk+ffGo8J 8Yah4cDczJsb+80s/Tktp7u3/uX0WY9A6dH94ocKaMsKH7R4jWNkZyFORoBmgxMAu2mX xUzDQAsa+tS2IYN9e+hQ0PRnfoxShiUFlgiimIMzXpf9enhgFI1NMTeIcaBzrECmHhkz dz4Gi8HidNdt/dkHil67GnopcSHCpHlD4uyV1Nfetuv41w7G8Dg6yehp10Bd2nc+bqBx UmDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=noTFGAOjDjJhQHG2H3UQEPhUmxSGntXisFmxZzKD0D0=; b=Fmk6NFPOrsRdwO59OQrGeJ7JLxUCOoJkT6xFaDUChjcmTnBuv7Zk/fXtm6OvQs/G8q UJe9bwhkrMUoMNouIadwQupyY+F2D3/Gk7YBwpeD/fiasHQNGXN/zxLS5HCEB+h/i+Re 1/tEpJswx0/KxInKJy3lo+atf4dqRvN58XkllNntpqNe6evFHZevTOKs4C2ieP/XxomU tq+oj1Bm7sTQ0R/npFHnqVecUKNM2RYXvJlqo/HErVL7A9qC3gsGP7QCRPLh0VpyLAMO KIb9mUi+bUY0n9+UTPDZP0mEoAs+lRLwywdaO/A1KEmwRaIx/Iuv5y41J1uQOvut7qGf VCdg== X-Gm-Message-State: AKGB3mKS/Q2RufcLOt4I/5jNQJgYDrsPilXrPOYwJGo2TmmJEiiFbE1F 6MEP3nw3Km9wdgg4+UZXJ2esmKBRGR7Gu9CYpPrfSw== X-Google-Smtp-Source: ACJfBousHJi/2p6KB9Y1ohdNowQr90123PvO231BkKGQ/B11rj71HRD7Zj4W5emTx2zAxWbrVDuDt2006idHv+44vZY= X-Received: by 10.36.133.135 with SMTP id r129mr41234098itd.69.1514412103889; Wed, 27 Dec 2017 14:01:43 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Wed, 27 Dec 2017 14:01:43 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:dd6a:b4e5:7da5:f5db] Received: by 10.79.108.204 with HTTP; Wed, 27 Dec 2017 14:01:43 -0800 (PST) In-Reply-To: References: <201712241759.vBOHxm5d005082@repo.freebsd.org> From: Warner Losh Date: Wed, 27 Dec 2017 15:01:43 -0700 X-Google-Sender-Auth: q4W53rbTmOpZq9Ucs0Eli1DdDww Message-ID: Subject: Re: svn commit: r327166 - head/sys/x86/isa To: John Baldwin Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 22:01:45 -0000 On Dec 27, 2017 2:56 PM, "John Baldwin" wrote: On 12/24/17 9:59 AM, Warner Losh wrote: > Author: imp > Date: Sun Dec 24 17:59:48 2017 > New Revision: 327166 > URL: https://svnweb.freebsd.org/changeset/base/327166 > > Log: > Further investigation shows this shouldn't have been added at all. > Remove it. > > Modified: > head/sys/x86/isa/orm.c > > Modified: head/sys/x86/isa/orm.c > ============================================================ ================== > --- head/sys/x86/isa/orm.c Sun Dec 24 16:53:55 2017 (r327165) > +++ head/sys/x86/isa/orm.c Sun Dec 24 17:59:48 2017 (r327166) > @@ -156,7 +156,6 @@ orm_identify(driver_t* driver, device_t parent) > device_set_desc(child, "ISA Option ROM"); > else > device_set_desc(child, "ISA Option ROMs"); > -// isa_set_vendorid(child, PNP_EISAID("PNP0C80")); > } So does this mean orm0 will trigger warnings in GENERIC now? No. The setting was redundant. Warner