From owner-svn-src-all@freebsd.org Tue Dec 5 11:54:54 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE87FE5FA2C; Tue, 5 Dec 2017 11:54:54 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5D14177596; Tue, 5 Dec 2017 11:54:54 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1129) id 9B03CF04F; Tue, 5 Dec 2017 11:54:53 +0000 (UTC) Date: Tue, 5 Dec 2017 11:54:53 +0000 From: Li-Wen Hsu To: Eitan Adler Cc: Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee Message-ID: <20171205115453.GA87559@freefall.freebsd.org> References: <201712050355.vB53tApl074041@repo.freebsd.org> <20171205084345.GR2272@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20171205084345.GR2272@kib.kiev.ua> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 11:54:54 -0000 On Tue, Dec 05, 2017 at 10:43:45 +0200, Konstantin Belousov wrote: > On Tue, Dec 05, 2017 at 03:55:10AM +0000, Eitan Adler wrote: > > Author: eadler > > Date: Tue Dec 5 03:55:10 2017 > > New Revision: 326554 > > URL: https://svnweb.freebsd.org/changeset/base/326554 [...] > > Added: head/usr.bin/sponge/sponge.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/usr.bin/sponge/sponge.c Tue Dec 5 03:55:10 2017 (r326554) [...] > > + while (bufremain > 0) { > > + whichbuf =3D (bufremain < maxiovec) ? bufremain : maxiovec; > > + bufremain -=3D whichbuf; > > + > > + i =3D writev(fd, iov, whichbuf); > > + if (i < 0) { > > + err(1, "failed to write"); > > + } > > + } > This loop is nonsensical. Also breaks build: /usr/src/usr.bin/sponge/sponge.c:175:25: error: comparison of integers of d= ifferent signs: 'size_t' (aka 'unsigned long') and 'long' [-Werror,-Wsign-c= ompare] whichbuf =3D (bufremain < maxiovec) ? bufremain : maxiovec; ~~~~~~~~~ ^ ~~~~~~~~ 1 error generated. Ref: https://ci.freebsd.org/job/FreeBSD-head-amd64-build/6187/console Please check this. Thanks, Li-Wen --=20 Li-Wen Hsu https://lwhsu.org