From owner-freebsd-arch  Fri Mar 16 17:18:52 2001
Delivered-To: freebsd-arch@freebsd.org
Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP id 8AED537B71C
	for <freebsd-arch@freebsd.org>; Fri, 16 Mar 2001 17:18:49 -0800 (PST)
	(envelope-from dima@unixfreak.org)
Received: from spike.unixfreak.org (spike [192.168.2.4])
	by bazooka.unixfreak.org (Postfix) with ESMTP
	id EA9083E1E; Fri, 16 Mar 2001 17:18:47 -0800 (PST)
To: James Housley <jim@thehousleys.net>
Cc: freebsd-arch@freebsd.org
Subject: Re: Inherate nodump cause significant slow down of dump 
In-Reply-To: <3AB2B8BA.29C5E58E@thehousleys.net>; from jim@thehousleys.net on "Fri, 16 Mar 2001 20:07:06 -0500"
Date: Fri, 16 Mar 2001 17:18:47 -0800
From: Dima Dorfman <dima@unixfreak.org>
Message-Id: <20010317011847.EA9083E1E@bazooka.unixfreak.org>
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

James Housley <jim@thehousleys.net> writes:
> The changes to src/sbin/dump/traverse.c (1.10.2.2) cause significant
> slow down of the dump estimate phase.  Specifically Phase II.  My /usr
> partition has about 2.5G of data including ports.  I had just the
> /usr/ports director flagged as nodump.  I think that this needs to be
> backed out, or fixed before the 4.3-RELEASE.

I'm not terribly opposed to this, but OTOH I don't see why it's
necessary.  The slowdown only occurs if you set nodump on a directory.
With the old behavior, this wouldn't do anything useful (AFAIK), so if
you have nodump on a directory, you probably expect the new behavior.
The latter has a problem with taking more time than it should (I think
it actually takes the same amount of time as dumping everything under
the nodump'd directory would).  In other words, the only thing that's
broken is the new feature.

> chflags nodump /usr/ports ; dump 0hsf 0 1048576 /dev/null /dev/ad0s1f 
>   -- this takes 38 minutes to finish Phase II for version 1.10.2.1 of
> src/sbin/dump/traverse.c

ITYM 1.10.2.2

Regards

					Dima Dorfman
					dima@unixfreak.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message