From owner-freebsd-current@freebsd.org Wed Mar 2 08:16:25 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C62F2ABF334; Wed, 2 Mar 2016 08:16:25 +0000 (UTC) (envelope-from zakharov.vv@gmail.com) Received: from mail-lb0-x22d.google.com (mail-lb0-x22d.google.com [IPv6:2a00:1450:4010:c04::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D04E12D5; Wed, 2 Mar 2016 08:16:25 +0000 (UTC) (envelope-from zakharov.vv@gmail.com) Received: by mail-lb0-x22d.google.com with SMTP id of3so113418959lbc.1; Wed, 02 Mar 2016 00:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Vsa7PwwXK1TRqz3Lht3bqB7dr0BFbftoAk4iimzlRC8=; b=Rh4sgwuKyY+q7iomuOgeEtzrOD7HkWmfxK7VEwh8YDmhC+rD4nsiLalrtN11Ut+eNu Na2M+lU8dN/tACH6Fx+y/vgods4RVr8wk91szLF+BCqffonrZoe0EMi1XE3KZqgiaFkS imBCbIeSgzIUe3Rs/YTpGFs46RbjU8cQuY11bTMoEFFquZBScWWXOEnJS48YVzlfSvL1 DwVqBWn5x7TbWutvniTRXSBQc5UlAYYKJR8/vwnOTOHopKXhaQfK8bh6cZYSNZCiYx7a G40l8SRNFHQOMlQcVdK9aI9jAxo99yk30JbC9ZY+y9D9/8tW9ayudHTwtwCUEme8JzJB JRhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Vsa7PwwXK1TRqz3Lht3bqB7dr0BFbftoAk4iimzlRC8=; b=IviNvulNGzXTjlQz5JB7gnO5uLjyJ8UYYFpap93JFuKZpNMumnHrf/r+J4tS+auBtp hBZqBCFT8DXCJp800CMoQEGS6RKgenmt08zVU28q80r550f3fIerJwaTPI8kR/7bjz1+ rPF+eAdGSheSpQwHBw00EzHhEN6Wa0z56PAG3OFr65ClW4NdBkA5TZ6JQZhBPClbldEv LC3bB3p28dRMSIi62yN3T4t1kmgnesYR4M4Q424/W/yVCQHntqtLGRFp+NT965dlcJH9 vFrjQMtxLHfa/0mqSvd+20tBhdUE94IQZXrzRY3tluy1dYa6fiiugEvXft9YDHRnPJgk mxKA== X-Gm-Message-State: AD7BkJKCMHKF7udzBLmMtpLxA9G9iTH/mMoGCxNt+/lc9Mtz8B9WQNGHrHh3pfT68mymOw== X-Received: by 10.112.235.71 with SMTP id uk7mr9301370lbc.39.1456906583190; Wed, 02 Mar 2016 00:16:23 -0800 (PST) Received: from localhost ([46.148.229.244]) by smtp.gmail.com with ESMTPSA id cc7sm5398018lbd.11.2016.03.02.00.16.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Mar 2016 00:16:22 -0800 (PST) Date: Wed, 2 Mar 2016 11:16:21 +0300 From: Vladimir Zakharov To: Michael Butler Cc: freebsd-current , "freebsd-emulation@freebsd.org" Subject: Re: SVN r296272 breaks virtualbox Message-ID: <20160302081621.GA29906@vzakharov> References: <56D617D1.5040209@protected-networks.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56D617D1.5040209@protected-networks.net> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-PGP-Key: http://vzakharov.ru/pubkey.asc User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 08:16:25 -0000 On Tue, Mar 01, 2016, Michael Butler wrote: > The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: > > Mar 1 16:54:36 toshi kernel: vboxdrv: fAsync=0 offMin=0x914 offMax=0x151c > Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol > taskqueue_enqueue_fast undefined > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol > taskqueue_enqueue_fast undefined > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > Mar 1 16:54:36 toshi kernel: KLD vboxnetadp.ko: depends on vboxnetflt - > not available or version mismatch > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type Attached patch for emulators/virtualbox-ose and rebuilding virtualbox-ose and virtualbox-ose-kmod fixed problem for me. ======================= --- files/patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c.orig 2016-03-02 10:15:39.814893000 +0300 +++ files/patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c 2016-03-02 10:16:39.070847000 +0300 @@ -1,10 +1,5 @@ -Add VLAN trunking support to vboxnetflt - -See: http://lists.freebsd.org/pipermail/freebsd-emulation/2012-April/009698.html -See: http://lists.freebsd.org/pipermail/freebsd-emulation/2013-May/010605.html -Submitted by: Landon J Fuller ---- ./src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c.orig 2013-04-12 06:38:11.000000000 -0400 -+++ ./src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c 2013-05-25 20:14:52.152180452 -0400 +--- src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c.orig 2016-01-19 22:18:38.000000000 +0300 ++++ src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c 2016-03-02 10:10:21.181922000 +0300 @@ -51,6 +51,7 @@ #include #include @@ -13,6 +8,24 @@ #include #include +@@ -369,7 +370,7 @@ + mtx_lock_spin(&pThis->u.s.inq.ifq_mtx); + _IF_ENQUEUE(&pThis->u.s.inq, m); + mtx_unlock_spin(&pThis->u.s.inq.ifq_mtx); +- taskqueue_enqueue_fast(taskqueue_fast, &pThis->u.s.tskin); ++ taskqueue_enqueue(taskqueue_fast, &pThis->u.s.tskin); + } + /* + * Handle mbufs on the outgoing hook, frames going to the interface +@@ -387,7 +388,7 @@ + mtx_lock_spin(&pThis->u.s.outq.ifq_mtx); + _IF_ENQUEUE(&pThis->u.s.outq, m); + mtx_unlock_spin(&pThis->u.s.outq.ifq_mtx); +- taskqueue_enqueue_fast(taskqueue_fast, &pThis->u.s.tskout); ++ taskqueue_enqueue(taskqueue_fast, &pThis->u.s.tskout); + } + else + { @@ -427,6 +428,8 @@ struct ifnet *ifp = pThis->u.s.ifp; unsigned int cSegs = 0; ======================= -- Regards, | "In theory there is no difference between theory Vladimir Zakharov | and practice. In practice there is."- Yogi Berra