From owner-cvs-src@FreeBSD.ORG Sun Jul 6 18:20:41 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C67A37B401; Sun, 6 Jul 2003 18:20:41 -0700 (PDT) Received: from smtp4.server.rpi.edu (smtp4.server.rpi.edu [128.113.2.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61E9343FB1; Sun, 6 Jul 2003 18:20:40 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp4.server.rpi.edu (8.12.9/8.12.9) with ESMTP id h671Kc63001315; Sun, 6 Jul 2003 21:20:38 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20030707003216.GI72093@elvis.mu.org> References: <200307061244.h66CiBqg079835@repoman.freebsd.org> <20030707003216.GI72093@elvis.mu.org> Date: Sun, 6 Jul 2003 21:20:37 -0400 To: Alfred Perlstein From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: unclaimed-spam X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Philippe Charnier Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2003 01:20:41 -0000 At 5:32 PM -0700 7/6/03, Alfred Perlstein wrote: >* Garance A Drosihn [030706 16:17] wrote: > > >> Speaking only for lpd, I wish you would not have added FBSDID. >> I had started to add FBSDID to all the source files of >> lpr & friends, and found that it was just annoying when I >> then went to build lpr on other platforms. So, I switched > > back to just plain 'rcsid[] ='. >> > >Isn't there a common header where you can just add: > >#ifndef __FBSDID >#define __FBSDID(s) struct __hack >#endif > >? Well, any change to use __FBSDID() has to #include to get FBSDID() to work. Of course, /usr/include/sys/cdefs.h does not exist on all platforms either (and is certainly not likely to define __FBSDID even if the file does exist), so that's just more of an annoyance when I'm doing cross-platform work. Other than the #include for sys/cdefs.h, there *is* no include before the reference to __FBSDID in any source file, due to the standard ordering of lines in a source file. I remember asking about this with a few people before I decided to stick with rcsid instead of FBSDID(), but I don't remember if that was in a mailing list or in private email. It looks like I had only committed a change to use FBSDID() in one file, lpr/chkprintcap/skimprintcap.c, and the comment when I switched that back to rcsid says "discussed with bde and obrien", so it was probably just private email. I thought I had switched more source files to use FBSDID, but it looks like that was the only file where I had made a commit that I later backed out. I was probably in the middle of an update to switch all the rest of the files when I started to realize what an added hassle it was going to be for me. [ ignoring that question for the moment, why would I want to define __FBSDID as 'struct __hack'? ] Yes, there are ways I can get around all of these minor issues, but at the time it seemed like a lot of extra futzing around for very little gain. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu