From owner-svn-src-all@freebsd.org  Tue Jan 14 03:36:26 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id F23221F8A0B;
 Tue, 14 Jan 2020 03:36:26 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 47xbj664B3z4YG0;
 Tue, 14 Jan 2020 03:36:26 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from [192.168.0.5] (unknown [181.52.72.201])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: pfg)
 by smtp.freebsd.org (Postfix) with ESMTPSA id EDCCC7779;
 Tue, 14 Jan 2020 03:36:25 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Subject: Re: svn commit: r356714 - head/sys/ufs/ffs
To: Jeff Roberson <jeff@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <202001140200.00E20OY4086656@repo.freebsd.org>
From: Pedro Giffuni <pfg@FreeBSD.org>
Organization: FreeBSD
Message-ID: <7c2872cd-3178-8cf0-ee47-7aea7f00285b@FreeBSD.org>
Date: Mon, 13 Jan 2020 22:36:24 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <202001140200.00E20OY4086656@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jan 2020 03:36:27 -0000


On 13/01/2020 21:00, Jeff Roberson wrote:
> Author: jeff
> Date: Tue Jan 14 02:00:24 2020
> New Revision: 356714
> URL: https://svnweb.freebsd.org/changeset/base/356714
>
> Log:
>    Fix a long standing bug in journaled soft-updates.  The dirrem structure
>    needs to handle file removal, directory removal, file move, directory move,
>    etc.  The code in handle_workitem_remove() needs to propagate any completed
>    journal entries to the write that will render the change stable.  In the
>    case of a moved directory this means the new parent.  However, for an
>    overwrite that frees a directory (DIRCHG) we must move the jsegdep to the
>    removed inode to be released when it is stable in the cg bitmap or the
>    unlinked inode list.  This case was previously unhandled and caused a
>    panic.
>    
>    Reported by:	mckusick, pho
>    Reviewed by:	mckusick
>    Tested by:	pho

MFC ? I mean if it's a long standing bug + unhandled + causing a panic 
... sounds like it really should be merged.

Pedro.