From owner-freebsd-current@FreeBSD.ORG Thu Dec 18 21:06:44 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BE981065747 for ; Thu, 18 Dec 2008 21:06:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 253DF8FC16 for ; Thu, 18 Dec 2008 21:06:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LDQ4v-000OAK-LY; Thu, 18 Dec 2008 23:06:41 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id mBIL6ZnC055430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Dec 2008 23:06:35 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id mBIL6Y0g014957; Thu, 18 Dec 2008 23:06:34 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id mBIL6Ykn014956; Thu, 18 Dec 2008 23:06:34 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 18 Dec 2008 23:06:34 +0200 From: Kostik Belousov To: pluknet Message-ID: <20081218210634.GL2038@deviant.kiev.zoral.com.ua> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vRyMahX6VF+pdQvX" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LDQ4v-000OAK-LY dcc41b3f62811306bb101cef806ccbb7 X-Terabit: YES Cc: freebsd-current Subject: Re: LOR between nfs and proctree X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2008 21:06:44 -0000 --vRyMahX6VF+pdQvX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 18, 2008 at 01:43:38AM +0300, pluknet wrote: > I didn't find this LOR in archives and don't know if this is known > one, so I'm posting it here. >=20 > lock order reversal: > 1st 0xc5ea37ac nfs (nfs) @ /usr/src/sys/kern/vfs_vnops.c:531 > 2nd 0xc0889090 proctree (proctree) @ /usr/src/sys/kern/kern_fork.c:311 > KDB: stack backtrace: > db_trace_self_wrapper(c07fb0cf,e7d1f8cc,c05d79e5,4,c07f662d,...) at > db_trace_self_wrapper+0x26 > kdb_backtrace(4,c07f662d,c54fcad8,c54f6068,e7d1f928,...) at kdb_backtrace= +0x29 > _witness_debugger(c07fdd7f,c0889090,c07f702d,c54f6068,c07f3e44,...) at > _witness_debugger+0x25 > witness_checkorder(c0889090,1,c07f3e44,137,0,...) at witness_checkorder+0= x839 > _sx_slock(c0889090,0,c07f3e44,137,0,...) at _sx_slock+0x85 > fork1(c0887530,60034,0,e7d1f9c0,c07f662d,...) at fork1+0x2cd > kproc_create(c06dc780,c09f8920,0,40000,0,...) at kproc_create+0x47 > nfs_nfsiodnew(c09f8f70,0,c080e39a,553,0,...) at nfs_nfsiodnew+0xc5 > nfs_asyncio(c5c024e8,d952b670,c5af0000,c5abdd80,0,...) at nfs_asyncio+0x3= a5 > nfs_bioread(c5ea3754,e7d1fc58,20000,c5af0000,e7d1fba0,...) at nfs_bioread= +0x788 > nfs_read(e7d1fbc8,c5abdd80,c5e63968,c5abdd80,e7d1fbe8,...) at nfs_read+0x= 44 > VOP_READ_APV(c085d360,e7d1fbc8,c0805cb8,213,c5abde24,...) at VOP_READ_APV= +0xa5 > vn_read(c5e63968,e7d1fc58,c5af0000,0,c5abdd80,...) at vn_read+0x1ee > dofileread(e7d1fc58,ffffffff,ffffffff,0,c5e63968,...) at dofileread+0x96 > kern_readv(c5abdd80,4,e7d1fc58,e7d1fc78,1,...) at kern_readv+0x58 > read(c5abdd80,e7d1fcf8,c,c07fe5a8,c083f5c8,...) at read+0x4f > syscall(e7d1fd38) at syscall+0x2a3 > Xint0x80_syscall() at Xint0x80_syscall+0x20 > --- syscall (3, FreeBSD ELF32, read), eip =3D 0x281c7f93, esp =3D > 0xbfbfeaec, ebp =3D 0xbfbfec28 --- It is more or less known, nfs may create new nfsiod while holding vnode lock. Severity of the issue lowered with removal of the single-threading from the fork(), but it is still real. Workaround is to create required amount of nfsiod in advance. --vRyMahX6VF+pdQvX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklKu1oACgkQC3+MBN1Mb4g6YwCfY9zIWp0Zksu9igKVpm4M2jK+ XDAAn3kciBkJ9TsQIbt5h+zuwYQ/qC9r =laxd -----END PGP SIGNATURE----- --vRyMahX6VF+pdQvX--