Date: Wed, 7 Apr 2004 13:05:21 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Colin Percival <colin.percival@wadham.ox.ac.uk> Cc: Nate Lawson <nate@root.org> Subject: Re: cvs commit: src/sys/kern kern_timeout.c src/sys/sys callout.h src/share/man/man9 timeout.9 Message-ID: <200404071305.21311.jhb@FreeBSD.org> In-Reply-To: <6.0.1.1.1.20040407004244.03f85e80@imap.sfu.ca> References: <20040406230958.C01C616A545@hub.freebsd.org> <20040406162703.H30263@root.org> <6.0.1.1.1.20040407004244.03f85e80@imap.sfu.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 06 April 2004 07:52 pm, Colin Percival wrote: > >> int callout_stop(struct callout *); > >> +#define callout_stop(c) _callout_stop_safe(c, 0) > > > >The goal here is to keep binary compatibility (multiple defines of > >callout_stop)? > > The goal was binary compatibility; the callout_stop prototype was > still here because gcc complained while compiling kern_timeout.c > otherwise. If there's a better solution, please let me know. You could move the prototype into kern_timeout.c to avoid having any code use it by accident. For what it's worth, I don't think preserving binary compatibility with 5.[012] is worth it for this function. I'd just axe the old one altogether. > >Are you > >going to remove that shim at some point? Perhaps a BURN_BRIDGES or > >GONE_IN_6 ifdef would be appropriate for that. > > I think this shim can be removed as soon as any modules which know > about callout_stop have been recompiled; I doubt it will take long > before someone makes a change which requires that to happen. :-) They all just got recompiled because callout.h changed. 3rd party modules will all be recompiled for 5.3 anyway, so I would recommend just going ahead and axeing it now. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404071305.21311.jhb>