Date: Wed, 23 Feb 2005 11:16:55 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Jeff Roberson <jroberson@chesapeake.net> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys vnode.h Message-ID: <61690.1109153815@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 23 Feb 2005 04:49:33 EST." <20050223044527.K52537@mail.chesapeake.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20050223044527.K52537@mail.chesapeake.net>, Jeff Roberson writes: >I didn't claim any performance degradation, because I'm sure you can't >measure any in world bench. It is simply a habbit of mine that I feel is >sound as it has made measurable differences in other datastructures. I agree about that in general, but the vnode is the undisputed king (or mother if you prefer) of complexity in our kernel, and we simply need to put that before any epsilon performance improvement. I wish one wouldn't have to forego source code clairity in order to havest performance benefits, but once we get into the territory of cacheline fits and similar things start to become very ugly source code wise. As long as we maintain the functional groupings I don't particularly care which order the groups come in or the order of elements in the groups. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?61690.1109153815>