From owner-freebsd-hackers  Fri Aug 16  5:30:20 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 67CAA37B400; Fri, 16 Aug 2002 05:30:16 -0700 (PDT)
Received: from scaup.mail.pas.earthlink.net (scaup.mail.pas.earthlink.net [207.217.120.49])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2310543E72; Fri, 16 Aug 2002 05:30:16 -0700 (PDT)
	(envelope-from tlambert2@mindspring.com)
Received: from pool0003.cvx22-bradley.dialup.earthlink.net ([209.179.198.3] helo=mindspring.com)
	by scaup.mail.pas.earthlink.net with esmtp (Exim 3.33 #1)
	id 17fgEw-0003pR-00; Fri, 16 Aug 2002 05:30:06 -0700
Message-ID: <3D5CEEB8.EFDBF659@mindspring.com>
Date: Fri, 16 Aug 2002 05:23:20 -0700
From: Terry Lambert <tlambert2@mindspring.com>
X-Mailer: Mozilla 4.79 [en] (Win98; U)
X-Accept-Language: en
MIME-Version: 1.0
To: Maxim Sobolev <max@vega.com>
Cc: Iasen Kostov <ikostov@otel.net>,
	Julian Elischer <julian@elischer.org>,
	Maxim Sobolev <sobomax@FreeBSD.ORG>, hackers@FreeBSD.ORG,
	net@FreeBSD.ORG
Subject: Re: Increasing size of if_flags field in the ifnet structure [patch
References: <200208161222.g7GCM8Rt005388@vega.vega.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

Maxim Sobolev wrote:
> > > There is no much point in this patch, because it will increase size of
> > > struct  ifreq, which means that no ioctl's from older apps will be accepted
> > > anyway. Therefore, there is no difference between those two, while my
> > > approach is obviously cleaner.
> >
> >   It does not increase size of struct ifreq.
> >   This is a union not a struct as You see.
> 
> Oh, yes, you are obviously correct. However, I still wonder if your patch
> is endianless-safe.

It's not, unless the structure packing is "just so".  First thing
I notices, and exactly what Bruce was pointing out when he referred
to "other architectures", I think.

-- Terry

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message