Date: Thu, 15 Apr 2004 02:32:48 -0500 (CDT) From: Mike Silbersack <silby@silby.com> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/random randomdev.c Message-ID: <20040415023200.D10243@odysseus.silby.com> In-Reply-To: <200404132258.31816.jhb@FreeBSD.org> References: <200404120913.i3C9DOkd075451@repoman.freebsd.org> <200404132258.31816.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 13 Apr 2004, John Baldwin wrote: > You should drop the lock before uiomove(). If the uio can possibly reference > user memory, then uiomove() will do a copyout() which can fault and thus > sleep if the page is in swap. > > -- > John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ I'm going to have a similar problem in sendfile when I try to de-giantify it, and I'm sure read / write will have issues as well... will WITNESS catch this potential problem? Mike "Silby" Silbersack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040415023200.D10243>