Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Dec 2015 22:59:58 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r287084 - in stable/10/usr.sbin/pw: . tests
Message-ID:  <20151202215958.GD20169@ivaldir.etoilebsd.net>
In-Reply-To: <867fkxcbq9.fsf@desk.des.no>
References:  <201508232142.t7NLgSXX033227@repo.freebsd.org> <867fkxcbq9.fsf@desk.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help

--eheScQNz3K90DVRs
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 02, 2015 at 12:48:46PM +0100, Dag-Erling Sm=F8rgrav wrote:
> Baptiste Daroussin <bapt@FreeBSD.org> writes:
> > Log:
> >   MFC: r285133,r285136,r285137,r285156,r285157,r285158,r285256,r285318,=
r285395,
> >   r285396,r285398,r285401,r285403,r285405,r285406,r285408,r285409,r2854=
11,
> >   r285412,r285413,r285415,r285418,r285430,r285433,r285434,r285442,r2859=
48,
> >   r285984,r285985,r285989,r285996,r285997,r286045,r286047,r286066,r2861=
50,
> >   r286151,r286152,r286154,r286155,r286156,r286157,r286173,r286196,r2861=
97,
> >   r286198,r286199,r286200,r286201,r286202,r286203,r286204,r286210,r2862=
11,
> >   r286217,r286218,r286258,r286259,r286341,r286775,r286982,r286986,r2869=
91,
> >   r286993
> >  =20
> >   Validate most pw inputs.
>=20
> This is a serious regression as the validation code is not locale-aware.
> I would like to see it reverted and an EN issued.  Fixing it correctly
> will be a major undertaking since it would needs to support multibyte
> locales.  In the meantime, I will have to replace pw on my 10.2 systems
> with the 10.1 binary.

Or a fix can be made, if you provide an example of the failing case, I woul=
d be
able to fix it and add it to the regression tests.

Bapt

--eheScQNz3K90DVRs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlZfad4ACgkQ8kTtMUmk6Ew7HACZASh0SzQaIL5BaCS1wzhk8Ht3
+SQAnRb91DnXqU32LTV0LbK3h3eSWwCi
=azVL
-----END PGP SIGNATURE-----

--eheScQNz3K90DVRs--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151202215958.GD20169>