From owner-svn-src-stable@freebsd.org Wed Dec 2 22:00:03 2015 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6F0A7A3FAC2; Wed, 2 Dec 2015 22:00:03 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 018521D7A; Wed, 2 Dec 2015 22:00:03 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wmvv187 with SMTP id v187so276403648wmv.1; Wed, 02 Dec 2015 14:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=0Afh+trTDzdA4O1sBFLTWcx9Bb0Bm2TAsW3C+H73XEE=; b=STESocOSCi+Zm5Yv0SCmnmRJ+7ZxGOZPlJjXaENj4WD0bYqc7wM4zFUHIHfHRP6Q/Y cYD3Y5Nk2B3QIdqBYgyqfQonME3PXCMda6IdfAnjSLp5gu08YL3Dd6aU2nN5FzRaHXmx iFCjltsdsb2KSiiHBMytXAnSild792Najymn/48VAJIaPTdt0scfEo2iMUgYo2bNVkiP q4wcOzq4apkVLcwciBNgMdrIkelpICzgfhh1qvnYDFzih8peaJwInsev7YyGjPSnp3Xm 6USkoTCm2nqCWPMbbniZldwKkjYgX7ATo9Vbj4iPaO7u/hPhSqFi7Zofs40xmtVjgyYN SiOA== X-Received: by 10.28.158.75 with SMTP id h72mr8404705wme.74.1449093601564; Wed, 02 Dec 2015 14:00:01 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id l128sm32482524wmf.10.2015.12.02.14.00.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Dec 2015 14:00:00 -0800 (PST) Sender: Baptiste Daroussin Date: Wed, 2 Dec 2015 22:59:58 +0100 From: Baptiste Daroussin To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r287084 - in stable/10/usr.sbin/pw: . tests Message-ID: <20151202215958.GD20169@ivaldir.etoilebsd.net> References: <201508232142.t7NLgSXX033227@repo.freebsd.org> <867fkxcbq9.fsf@desk.des.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eheScQNz3K90DVRs" Content-Disposition: inline In-Reply-To: <867fkxcbq9.fsf@desk.des.no> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 22:00:03 -0000 --eheScQNz3K90DVRs Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 02, 2015 at 12:48:46PM +0100, Dag-Erling Sm=F8rgrav wrote: > Baptiste Daroussin writes: > > Log: > > MFC: r285133,r285136,r285137,r285156,r285157,r285158,r285256,r285318,= r285395, > > r285396,r285398,r285401,r285403,r285405,r285406,r285408,r285409,r2854= 11, > > r285412,r285413,r285415,r285418,r285430,r285433,r285434,r285442,r2859= 48, > > r285984,r285985,r285989,r285996,r285997,r286045,r286047,r286066,r2861= 50, > > r286151,r286152,r286154,r286155,r286156,r286157,r286173,r286196,r2861= 97, > > r286198,r286199,r286200,r286201,r286202,r286203,r286204,r286210,r2862= 11, > > r286217,r286218,r286258,r286259,r286341,r286775,r286982,r286986,r2869= 91, > > r286993 > > =20 > > Validate most pw inputs. >=20 > This is a serious regression as the validation code is not locale-aware. > I would like to see it reverted and an EN issued. Fixing it correctly > will be a major undertaking since it would needs to support multibyte > locales. In the meantime, I will have to replace pw on my 10.2 systems > with the 10.1 binary. Or a fix can be made, if you provide an example of the failing case, I woul= d be able to fix it and add it to the regression tests. Bapt --eheScQNz3K90DVRs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlZfad4ACgkQ8kTtMUmk6Ew7HACZASh0SzQaIL5BaCS1wzhk8Ht3 +SQAnRb91DnXqU32LTV0LbK3h3eSWwCi =azVL -----END PGP SIGNATURE----- --eheScQNz3K90DVRs--