From owner-freebsd-wireless@FreeBSD.ORG  Fri Dec 30 19:55:10 2011
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CB974106564A
	for <freebsd-wireless@freebsd.org>;
	Fri, 30 Dec 2011 19:55:10 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com
	[209.85.212.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 7E9778FC14
	for <freebsd-wireless@freebsd.org>;
	Fri, 30 Dec 2011 19:55:10 +0000 (UTC)
Received: by vbbfr13 with SMTP id fr13so19561275vbb.13
	for <freebsd-wireless@freebsd.org>;
	Fri, 30 Dec 2011 11:55:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=DpvuGzjkezaST5MdN5Q919NWcWqqxzPt95eiNlvS304=;
	b=MXxeYmtxV8FumjR7nIMPJCnZPJXGseBg8LjuGiQz0ov23k4X5ic2JbSA0mz+jVDt5p
	h7OejCGk8oDWSoIP9NNByguNnwIbXt0JL+l5VvnhHwh0XdxlM8Rpr4HomYkXjmJmLDmg
	JoUuDLGwOzIewlSYO2i0n5oGndOQrD8h4s19Y=
MIME-Version: 1.0
Received: by 10.52.33.99 with SMTP id q3mr19330389vdi.100.1325274909909; Fri,
	30 Dec 2011 11:55:09 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.52.36.5 with HTTP; Fri, 30 Dec 2011 11:55:09 -0800 (PST)
In-Reply-To: <CAB96EKRBLN2cvavtESFH0okBOBuHXVb9Gs2rjaiCT4UqeC==0A@mail.gmail.com>
References: <CAB96EKRBLN2cvavtESFH0okBOBuHXVb9Gs2rjaiCT4UqeC==0A@mail.gmail.com>
Date: Fri, 30 Dec 2011 11:55:09 -0800
X-Google-Sender-Auth: 16-mDvVAa8YzUvxupUEOhUGUctE
Message-ID: <CAJ-VmomOE07qjpez6DFaDUBSkRR8QwUe05HYFyJ-=t1FA14pQg@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Philippe Saint-Pierre <stpere@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-wireless@freebsd.org
Subject: Re: patch proposal for marvell driver
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Dec 2011 19:55:10 -0000

On 30 December 2011 10:10, Philippe Saint-Pierre <stpere@gmail.com> wrote:
> Hi,
>
> I'm sending this small patch for the marvell wifi driver.
>
> Basically, in mwl_hal_bastream_alloc(), there is a sp = ... assignment that
> could return NULL, then several derefencing of sp then finally, a NULL
> check on sp before returning.
>
> I simply moved the NULL check before the dereferences tries occurs.

Thanks for noticing this! I haven't yet tried any of the mwl cards Sam gave me.
Would you mind throwing this into a PR?

Thanks,


Adrian