Date: Mon, 24 Mar 2008 04:21:59 +0300 (MSK) From: Dmitry Lohansky <sq@tvfaq.ru> To: FreeBSD-gnats-submit@FreeBSD.org Cc: d.lohansky@zsupport.ru Subject: ports/122027: Fix several zabbix-server crashes Message-ID: <200803240121.m2O1LxWJ093262@tvfaq.ru> Resent-Message-ID: <200803240130.m2O1U0GS015955@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 122027
>Category: ports
>Synopsis: Fix several zabbix-server crashes
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 24 01:30:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Lohansky
>Release: FreeBSD 7.0-RELEASE i386
>Organization:
>Environment:
System: FreeBSD tvfaq.ru 7.0-RELEASE FreeBSD 7.0-RELEASE #1: Wed Mar 12 04:05:13 MSK 2008 root@tvfaq.ru:/usr/obj/usr/src/sys/TVFAQ i386
>Description:
1. Fix crashes when trying to do some actions
2. Fix crashes with pgsql
>How-To-Repeat:
>Fix:
--- patch-create__schema__postgresql.sql begins here ---
--- create/schema/postgresql.sql.orig 2007-12-17 16:31:01.000000000 +0300
+++ create/schema/postgresql.sql 2008-03-24 04:11:42.000000000 +0300
@@ -165,7 +165,7 @@
nodeid bigint DEFAULT '0' NOT NULL,
itemid bigint DEFAULT '0' NOT NULL,
clock integer DEFAULT '0' NOT NULL,
- value numeric(16,4) DEFAULT '0.0000' NOT NULL,
+ value numeric(24,4) DEFAULT '0.0000' NOT NULL,
PRIMARY KEY (id)
) with OIDS;
CREATE INDEX history_sync_1 on history_sync (nodeid,id);
@@ -230,7 +230,7 @@
CREATE TABLE history (
itemid bigint DEFAULT '0' NOT NULL,
clock integer DEFAULT '0' NOT NULL,
- value numeric(16,4) DEFAULT '0.0000' NOT NULL
+ value numeric(24,4) DEFAULT '0.0000' NOT NULL
) with OIDS;
CREATE INDEX history_1 on history (itemid,clock);
@@ -273,9 +273,9 @@
itemid bigint DEFAULT '0' NOT NULL,
clock integer DEFAULT '0' NOT NULL,
num integer DEFAULT '0' NOT NULL,
- value_min numeric(16,4) DEFAULT '0.0000' NOT NULL,
- value_avg numeric(16,4) DEFAULT '0.0000' NOT NULL,
- value_max numeric(16,4) DEFAULT '0.0000' NOT NULL,
+ value_min numeric(24,4) DEFAULT '0.0000' NOT NULL,
+ value_avg numeric(24,4) DEFAULT '0.0000' NOT NULL,
+ value_max numeric(24,4) DEFAULT '0.0000' NOT NULL,
PRIMARY KEY (itemid,clock)
) with OIDS;
CREATE TABLE acknowledges (
@@ -369,8 +369,8 @@
width integer DEFAULT '0' NOT NULL,
height integer DEFAULT '0' NOT NULL,
yaxistype integer DEFAULT '0' NOT NULL,
- yaxismin numeric(16,4) DEFAULT '0' NOT NULL,
- yaxismax numeric(16,4) DEFAULT '0' NOT NULL,
+ yaxismin numeric(24,4) DEFAULT '0' NOT NULL,
+ yaxismax numeric(24,4) DEFAULT '0' NOT NULL,
templateid bigint DEFAULT '0' NOT NULL,
show_work_period integer DEFAULT '1' NOT NULL,
show_triggers integer DEFAULT '1' NOT NULL,
--- patch-create__schema__postgresql.sql ends here ---
--- patch-src__libs__zbxdbhigh__db.c begins here ---
--- ./src/libs/zbxdbhigh/db.c.orig 2008-03-22 04:21:53.000000000 +0300
+++ ./src/libs/zbxdbhigh/db.c 2008-03-22 04:54:33.000000000 +0300
@@ -1789,10 +1789,10 @@
DBfree_result(result);
result = DBselect("select max(%3$s) from %4$s where %3$s>="ZBX_FS_UI64" and %3$s<="ZBX_FS_UI64,
- min,
- max,
fieldname,
- tablename);
+ tablename,
+ min,
+ max);
row = DBfetch(result);
if(!row || SUCCEED == DBis_null(row[0]) || !*row[0])
ret1 = min;
--- patch-src__libs__zbxdbhigh__db.c ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803240121.m2O1LxWJ093262>