From owner-svn-src-all@FreeBSD.ORG Tue Apr 16 17:11:32 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D6C62D1C; Tue, 16 Apr 2013 17:11:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) by mx1.freebsd.org (Postfix) with ESMTP id B3A829C0; Tue, 16 Apr 2013 17:11:32 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 241BAB962; Tue, 16 Apr 2013 13:11:32 -0400 (EDT) From: John Baldwin To: Hiren Panchasara Subject: Re: svn commit: r249461 - head/sys/dev/ips Date: Tue, 16 Apr 2013 12:10:08 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <201304140242.r3E2geSq094403@svn.freebsd.org> In-Reply-To: <201304140242.r3E2geSq094403@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201304161210.09058.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 16 Apr 2013 13:11:32 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2013 17:11:32 -0000 On Saturday, April 13, 2013 10:42:40 pm Hiren Panchasara wrote: > Author: hiren > Date: Sun Apr 14 02:42:40 2013 > New Revision: 249461 > URL: http://svnweb.freebsd.org/changeset/base/249461 > > Log: > Fixing a clang warning indicating uninitialized variable usage. > > PR: kern/177164 > Approved by: sbruno (mentor) Hmm, I always thought that dmatags and maps were opaque types and not necessarily "known" in consumers to be pointers. (Some drivers do check tehm against NULL implicitly via 'if (map)' or 'if (tag)', but well-behaved drivers use other means (flags, etc.) to know if they are valid.) -- John Baldwin