Date: Tue, 5 Dec 2017 10:29:47 -0800 From: Eitan Adler <eadler@freebsd.org> To: Eric Joyner <erj@erj.cc> Cc: Cy Schubert <Cy.Schubert@komquats.com>, Devin Teske <devin@shxd.cx>, Hans Petter Selasky <hps@selasky.org>, "rgrimes@freebsd.org" <rgrimes@freebsd.org>, "cem@freebsd.org" <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee Message-ID: <CAF6rxgmydTftejsX1d8ePHLTRuyS3f0PAEVL7nwgU-HbdKW%2BSw@mail.gmail.com> In-Reply-To: <CAKdFRZiCC89jtGRw2QoD-2UCcOdm_w02Q0=a3pwHOA8eNB18NA@mail.gmail.com> References: <20171205175029.64B7135B@spqr.komquats.com> <CAKdFRZiCC89jtGRw2QoD-2UCcOdm_w02Q0=a3pwHOA8eNB18NA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm not near my commit box right now so someone will have to revert it. What's funny is that I ran a complete 'make buildworld buildkernel' last night with this patch. Will respond to the rest of the thread later On 5 December 2017 at 10:08, Eric Joyner <erj@erj.cc> wrote: > I got told by a co-worker that this broke buildworld. Can this commit get > reverted/have the cast fixed? > > - Eric (erj) > > > On Tue, Dec 5, 2017 at 9:50 AM Cy Schubert <Cy.Schubert@komquats.com> wrote: >> >> Our sed already creates backup files "optionally" just as gsed does. Only >> the syntax is different. No need to sponge sed, just sed -i '' (whereas gsed >> is -i without the argument). >> >> >> --- >> Sent using a tiny phone keyboard. >> Apologies for any typos and autocorrect. >> This old phone only supports top post. Apologies. >> >> Cy Schubert >> <Cy.Schubert@cschubert.com> or <cy@freebsd.org> >> The need of the many outweighs the greed of the few. >> --- >> ________________________________ >> From: Devin Teske >> Sent: 05/12/2017 09:23 >> To: Cy Schubert >> Cc: Hans Petter Selasky; rgrimes@freebsd.org; cem@freebsd.org; Eitan >> Adler; src-committers; svn-src-all@freebsd.org; svn-src-head@freebsd.org >> >> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge >> usr.bin/sponge/tests usr.bin/tee >> >> >> On Dec 5, 2017, at 8:29 AM, Cy Schubert <Cy.Schubert@komquats.com> wrote: >> >> Why not update sed to create the backup file only if the suffix is given >> to -i, like gnu sed does. >> >> >> I suspect that would break countless scripts that test uname to determine >> how to use the -i flag of sed. >> -- >> Devin >> >> >> --- >> Sent using a tiny phone keyboard. >> Apologies for any typos and autocorrect. >> This old phone only supports top post. Apologies. >> >> Cy Schubert >> <Cy.Schubert@cschubert.com> or <cy@freebsd.org> >> The need of the many outweighs the greed of the few. >> --- >> ________________________________ >> From: Devin Teske >> Sent: 05/12/2017 07:35 >> To: Hans Petter Selasky >> Cc: rgrimes@freebsd.org; cem@freebsd.org; Eitan Adler; src-committers; >> svn-src-all@freebsd.org; svn-src-head@freebsd.org >> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge >> usr.bin/sponge/tests usr.bin/tee >> >> >> > On Dec 5, 2017, at 5:00 AM, Hans Petter Selasky <hps@selasky.org> wrote: >> > >> >> On 12/05/17 13:58, Rodney W. Grimes wrote: >> >> Further more, why does freebsd need this in base? >> > >> > Hi, >> > >> > I think this is useful. It could replace the "-i " (intermediate) option >> > for "sed" for example. It avoids creating temporary files when filtering >> > files, right? >> > >> > --HPS >> > >> >> Wth is wrong with: >> >> data=$( sed -e '...' somefile ) && >> echo "$data" > somefile >> >> or >> >> set -e >> data=... >> echo "$data" > ... >> >> or >> >> exec 3<<EOF >> $( ... ) >> EOF >> cat > ... <&3 >> >> or >> >> (I digress) >> >> Infinite variations, but the gist is that sponge looks to be trying to >> help sh(1)/similar when help is unneeded. >> >> Why buffer data into memory via fork-exec-pipe to sponge when you can >> buffer to native namespace without pipe to sponge? >> >> Am I missing something? Why do we need sponge(1)? >> -- >> Devin >> > -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgmydTftejsX1d8ePHLTRuyS3f0PAEVL7nwgU-HbdKW%2BSw>