Date: Sat, 24 Nov 2007 19:47:23 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Attilio Rao <attilio@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_lock.c src/sys/sys lockmgr.h Message-ID: <20071124194615.Y14018@fledge.watson.org> In-Reply-To: <200711240422.lAO4MSGT071285@repoman.freebsd.org> References: <200711240422.lAO4MSGT071285@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 24 Nov 2007, Attilio Rao wrote: > attilio 2007-11-24 04:22:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_lock.c > sys/sys lockmgr.h > Log: > transferlockers() is a very dangerous and hack-ish function as waiters > should never be moved by one lock to another. > As, luckily, nothing in our tree is using it, axe the function. > > This breaks lockmgr KPI, so interested, third-party modules should update > their source code with appropriate replacement. > > Ok'ed by: ups, rwatson "Ok'd by" doesn't generally seem to be a convention for FreeBSD commit messages--I'd suggest "discussed with" which makes it seem a bit less like approval, which is generally captured with "approved by". Robert N M Watson Computer Laboratory University of Cambridge > MFC after: 3 days > > Revision Changes Path > 1.113 +0 -28 src/sys/kern/kern_lock.c > 1.54 +0 -1 src/sys/sys/lockmgr.h >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071124194615.Y14018>