From owner-freebsd-fs@FreeBSD.ORG Sun Oct 11 00:03:59 2009 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF60B10656A9; Sun, 11 Oct 2009 00:03:59 +0000 (UTC) (envelope-from sten@blinkenlights.nl) Received: from mx1.blinkenlights.nl (mx1.blinkenlights.nl [IPv6:2a02:898:17:8000::25]) by mx1.freebsd.org (Postfix) with ESMTP id 4AAC48FC2E; Sun, 11 Oct 2009 00:03:59 +0000 (UTC) Received: from bastard.snore.nl (bastard.snore.nl [IPv6:2001:7b8:666:ffff:0:42ff:fe00:4]) by mx1.blinkenlights.nl (Postfix) with ESMTP id BEE311142A; Sun, 11 Oct 2009 02:03:58 +0200 (CEST) Received: by bastard.snore.nl (Postfix, from userid 1000) id A80C628A023; Sun, 11 Oct 2009 02:03:58 +0200 (CEST) X-Original-To: sten@blinkenlights.nl Delivered-To: sten@blinkenlights.nl Received: from mx0.blinkenlights.nl (mx0.blinkenlights.nl [IPv6:2a01:1b0:201:1::25]) by zaphod.blinkenlights.nl (Postfix) with ESMTP id E86388A049 for ; Tue, 25 Nov 2008 16:07:46 +0100 (CET) Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by mx0.blinkenlights.nl (Postfix) with ESMTP id 7C0E173009 for ; Tue, 25 Nov 2008 16:07:46 +0100 (CET) Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 2BDD317ABF1; Tue, 25 Nov 2008 15:05:30 +0000 (UTC) (envelope-from owner-freebsd-stable@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 05F911065693; Tue, 25 Nov 2008 15:05:29 +0000 (UTC) (envelope-from owner-freebsd-stable@freebsd.org) Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B1111065670 for ; Tue, 25 Nov 2008 15:05:06 +0000 (UTC) (envelope-from josh.carroll@gmail.com) Received: from mail-gx0-f12.google.com (mail-gx0-f12.google.com [209.85.217.12]) by mx1.freebsd.org (Postfix) with ESMTP id CDF7F8FC1E for ; Tue, 25 Nov 2008 15:05:05 +0000 (UTC) (envelope-from josh.carroll@gmail.com) Received: by gxk5 with SMTP id 5so321517gxk.19 for ; Tue, 25 Nov 2008 07:05:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=RRS1FXdk6KlOebjY9FSAS8fA0kl0y8YlEbfplRT45M0=; b=Jdoquum9NTRB8Y0QWe5f8nVgLb8KfQcg0Nt6AoMr9acbSrXoHEhV7gYmJrymn+7uwW Sw9ypTcOTH1ZR8JZ6e55Ii8jZ36ytrGvHULsbe9aLoYkI+CEMwR5t5stql0dU8B492Q6 Npv9G8Qdzt/ok6XTJQxB8TWm2JSo1p3K/UARI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:to:subject:cc:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:references; b=lsYAyPaKcTCUAIp/Wj2A4i6S4P+wIouowlWywrqAgdKywOQ/brvAQrjy/fq6EoQdDz 0+iFAW/TN5PGzkneHzVWCxSrEm5dbniD/tsv/135HgwW9S1uLJiV5BRVrwvK4riSd8tU HkCGK/J+VNsfPKDfHslQVJytvu0VuUBTeJb5E= Received: by 10.150.49.15 with SMTP id w15mr8563645ybw.152.1227625038227; Tue, 25 Nov 2008 06:57:18 -0800 (PST) Received: by 10.150.218.5 with HTTP; Tue, 25 Nov 2008 06:57:18 -0800 (PST) Message-ID: <8cb6106e0811250657q6fdf08b0x1e94f35fd0a7ed4f@mail.gmail.com> From: "Josh Carroll" To: "Kostik Belousov" In-Reply-To: <20081125142827.GI2042@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8cb6106e0811241129o642dcf28re4ae177c8ccbaa25@mail.gmail.com> <20081125140601.GH2042@deviant.kiev.zoral.com.ua> <8cb6106e0811250617q5fffb41exe20dfb8314fc4a9d@mail.gmail.com> <20081125142827.GI2042@deviant.kiev.zoral.com.ua> X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Sender: owner-freebsd-stable@freebsd.org Errors-To: owner-freebsd-stable@freebsd.org Cc: freebsd-fs@freebsd.org, FreeBSD Stable Subject: Re: ext2 inode size patch - RE: PR kern/124621 X-BeenThere: freebsd-fs@freebsd.org Reply-To: josh.carroll@gmail.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 11 Oct 2009 00:03:59 -0000 X-Original-Date: Tue, 25 Nov 2008 09:57:18 -0500 X-List-Received-Date: Sun, 11 Oct 2009 00:03:59 -0000 > I do not suggest testing. I suggest understand what inode metadata is stored > in the added 128 bytes and evaluate whether this information can be ignored > without dangerous consequences for filesystem consistency or user data. > Well, to be clear I didn't just double the size of the inode table. It is dynamically determined based on the data structure. I'm not a file system expert (to call me a novice would probably be stretching it), so I'm hoping someone more versed can chime in. All the code does is query the data structure (specifically, the s_inode_size field of the structure) and use that value instead of blindly assuming an inode size of 128. I don't think it's a matter of what is done with the extra bits, since it's just querying the size of an already created filesystem. Thanks, Josh _______________________________________________ freebsd-stable@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org"