Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Jan 2009 16:24:35 GMT
From:      Nathan Whitehorn <nwhitehorn@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 156869 for review
Message-ID:  <200901291624.n0TGOZDd092547@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=156869

Change 156869 by nwhitehorn@nwhitehorn_trantor on 2009/01/29 16:23:36

	Change the synchronization strategy for tlbie calls to correctly
	use ptesync and to avoid unnecessary sync operations at the end.

Affected files ...

.. //depot/projects/ppc-g5/sys/powerpc/aim/mmu_oea64.c#13 edit

Differences ...

==== //depot/projects/ppc-g5/sys/powerpc/aim/mmu_oea64.c#13 (text+ko) ====

@@ -191,8 +191,6 @@
 	uint64_t vpn;
 	register_t vpn_hi, vpn_lo;
 
-	SYNC();
-
 #if 1
 	/*
 	 * CPU documentation says that tlbie takes the VPN, not the
@@ -214,19 +212,17 @@
 	    clrldi %1,%0,49; \
 	    insrdi %1,1,1,0; \
 	    mtmsrd %1; \
-	    isync; \
+	    ptesync; \
 	    \
 	    sld %1,%2,%4; \
 	    or %1,%1,%3; \
 	    tlbie %1; \
 	    \
 	    mtmsrd %0; \
-	    isync;" 
+	    eieio; \
+	    tlbsync; \
+	    ptesync;" 
 	: "=r"(msr), "=r"(scratch) : "r"(vpn_hi), "r"(vpn_lo), "r"(32));
-
-	EIEIO();
-	TLBSYNC();
-	SYNC();
 }
 
 #define DISABLE_TRANS(msr)	msr = mfmsr(); mtmsr(msr & ~PSL_DR); isync()



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901291624.n0TGOZDd092547>