Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 Mar 2019 18:01:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        toolchain@FreeBSD.org
Subject:   [Bug 236216] devel/valgrind: clang 8 crashes during build
Message-ID:  <bug-236216-29464-nijtMbw5lv@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-236216-29464@https.bugs.freebsd.org/bugzilla/>
References:  <bug-236216-29464@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236216

--- Comment #4 from Dimitry Andric <dim@FreeBSD.org> ---
Created attachment 202554
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D202554&action=
=3Dedit
Reuse existing offsetof macro for clang 8's sake

This is regressed by upstream https://reviews.llvm.org/rL349561 ("Emit ASM
input in a constant context"), and I already filed an upstream bug here:

https://bugs.llvm.org/show_bug.cgi?id=3D40890

The cause is the custom my_offsetof() macro in genoffsets, which returns a
pointer, not an offset.  The attached patch makes it reuse the already exis=
ting
offsetof() macro from VEX/pub/libvex_basictypes.h, which does the right thi=
ng.

I think this is an acceptable workaround until upstream fixes the issue with
<https://reviews.llvm.org/rL349561>, or even as a permanent cleanup.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-236216-29464-nijtMbw5lv>