From owner-cvs-src@FreeBSD.ORG Thu Mar 24 21:01:58 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B85B316A4D1; Thu, 24 Mar 2005 21:01:58 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id E521243D5E; Thu, 24 Mar 2005 21:01:57 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j2OL1rwO006762; Thu, 24 Mar 2005 13:01:53 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j2OL1r1W006761; Thu, 24 Mar 2005 13:01:53 -0800 Date: Thu, 24 Mar 2005 13:01:53 -0800 From: Brooks Davis To: John Baldwin Message-ID: <20050324210153.GA6308@odin.ac.hmc.edu> References: <200503241751.j2OHpFQg063306@repoman.freebsd.org> <20050324200942.GK46915@wombat.fafoe.narf.at> <20050324201936.GA30850@odin.ac.hmc.edu> <200503241555.59177.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: <200503241555.59177.jhb@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: Brooks Davis cc: Stefan Farfeleder cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2005 21:01:59 -0000 --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 24, 2005 at 03:55:59PM -0500, John Baldwin wrote: > On Thursday 24 March 2005 03:19 pm, Brooks Davis wrote: > > On Thu, Mar 24, 2005 at 09:09:43PM +0100, Stefan Farfeleder wrote: > > > On Thu, Mar 24, 2005 at 12:02:10PM -0800, Brooks Davis wrote: > > > > Prior to C99, I think #error wasn't specified. C99 does specify it. > > > > > > C89/90 had #error too. > > > > I stand corrected. Now that I think about it, all but the perverse > > preprocessors would implement #error just by blowing up on an unknown > > directive so even that isn't an issue. In any case, I've made the > > change and the new code is at least shorter. It's really only there for > > people mucking with kernel internals who should be able to figure out > > what it means. >=20 > We could always just change CTASSERT() to use #error if that is better. #error would be better if we could change the CTASSERT prototype to output a useful error message. I suppose we could add a new macro that took an argument and implement CTASSERT in terms of it. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --Dxnq1zWXvFF0Q93v Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCQyrAXY6L6fI4GtQRAqzaAKC9DPLHJM3RbpFac9hWMkZIeF0hLgCdFqNe W1qn4si89nup4eYfx71HxSU= =eJUA -----END PGP SIGNATURE----- --Dxnq1zWXvFF0Q93v--