From owner-cvs-src@FreeBSD.ORG  Wed Nov 19 10:16:35 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2FFE116A4CE; Wed, 19 Nov 2003 10:16:35 -0800 (PST)
Received: from canning.wemm.org (canning.wemm.org [192.203.228.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 15C2244008; Wed, 19 Nov 2003 10:16:30 -0800 (PST)
	(envelope-from peter@wemm.org)
Received: from wemm.org (localhost [127.0.0.1])
	by canning.wemm.org (Postfix) with ESMTP
	id 69C132A8EB; Wed, 19 Nov 2003 10:16:30 -0800 (PST)
	(envelope-from peter@wemm.org)
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: John Baldwin <jhb@FreeBSD.ORG>, src-committers@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
In-Reply-To: <20031119162804.GA66857@VARK.homeunix.com> 
Date: Wed, 19 Nov 2003 10:16:30 -0800
From: Peter Wemm <peter@wemm.org>
Message-Id: <20031119181630.69C132A8EB@canning.wemm.org>
Subject: Re: cvs commit: src/sys/i386/isa atpic.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 18:16:35 -0000

David Schultz wrote:
> On Wed, Nov 19, 2003, John Baldwin wrote:
> > jhb         2003/11/19 07:40:23 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/i386/isa         atpic.c 
> >   Log:
> >   Add a special check for a stray IRQ 7 or IRQ 15 to see if it is actually
> >   a spurious interrupt from one of the 8259As.  If so, don't log it as a
> >   stray IRQ, but just silently ignore it.
> 
> Nice.  I've been waiting for years for someone who understood the
> full flakiness of the i8259 to fix the spurious messages.

Heh. sys/amd64/isa/ithread.c rev 1.22 had code to do this since may 1st,
but John discovered that I managed to invert some of the bit definitions.
It is amazing what you can discover when you actually read the data sheets.
:-)

Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5