From owner-cvs-src@FreeBSD.ORG Thu Aug 18 17:16:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29E1C16A421; Thu, 18 Aug 2005 17:16:55 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id D462E43D46; Thu, 18 Aug 2005 17:16:53 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.40.201] (Not Verified[10.50.40.201]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Thu, 18 Aug 2005 13:31:53 -0400 From: John Baldwin To: Maxim Sobolev Date: Thu, 18 Aug 2005 12:38:03 -0400 User-Agent: KMail/1.8 References: <200508181429.j7IET16d038533@repoman.freebsd.org> In-Reply-To: <200508181429.j7IET16d038533@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200508181238.05411.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2005 17:16:55 -0000 On Thursday 18 August 2005 10:29 am, Maxim Sobolev wrote: > sobomax 2005-08-18 14:29:01 UTC > > FreeBSD src repository > > Modified files: > sys/dev/re if_re.c > Log: > In re_shutdown() mark interface as down since otherwise we will panic if > interrupt comes in later on, which can happen in some uncommon cases. > > Another possible fix is to call re_detach() instead of re_stop(), like > ve(4) does, but I am not sure if the latter is really RTTD, so that stick > with this one-liner for now. > > PR: kern/80005 > Approved by: silence on -arch, no reply from selected network gurus The PR reports problems while the machine is running, not a panic during shutdown. I couldn't get the PR database to load the PR with the panic from vr(4) yesterday. It's very unclear why clearing IFF_UP makes any difference. Ah, perhaps re_intr() should be fixed to check IFF_DRV_RUNNING rather than IFF_UP? Then the re_stop() in re_shutdown() would be sufficient. I also think that the change to vr(4) should be reverted (way too big of a sledge hammer) and instead its interrupt handler can check IFF_DRV_RUNNING and bail if it is clear as well. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org