From owner-svn-src-stable@freebsd.org Wed Dec 2 22:37:49 2015 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB658A3F5AE; Wed, 2 Dec 2015 22:37:48 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 806ED1EBB; Wed, 2 Dec 2015 22:37:48 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wmec201 with SMTP id c201so974338wme.0; Wed, 02 Dec 2015 14:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=zhLDrXi74ry04n8Ag51bemRZdS2QHRmk38DLsHkhpY0=; b=B/mTWbw1QAzsJbJQpZ8b+e7CayR8opb7pDYGLagyJPQ+jE3iCLZAl0ZNc4hnQ/Boms dB0nEqgv3OUkocy/SDI5UtYFK8SvABsDEAu+qyvzI3h+pgYMyrjFacfmE32Mx46iqFSC 0lpzidcMRAJB62iA5SoQ0ePteEpFWPk6fBl0FQUuj357QZZ4Mcx/OsvpJrp9wzNR0pJh RkyyQa0oG7A91XsnikL0vUIskA+LdmZ6629TUPbQMdcquJfFe9L3sFfHq8UFO6bPr3Y7 4nW1Ez5dLRUctiQ8cyYlEuNWt+veasZoD5kSJ3c0o1P9+nhZKvS9O0jknSWeUKjqHpu+ CuSQ== X-Received: by 10.28.8.15 with SMTP id 15mr48510803wmi.50.1449095866624; Wed, 02 Dec 2015 14:37:46 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id u134sm32869029wmd.0.2015.12.02.14.37.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Dec 2015 14:37:45 -0800 (PST) Sender: Baptiste Daroussin Date: Wed, 2 Dec 2015 23:37:43 +0100 From: Baptiste Daroussin To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r287084 - in stable/10/usr.sbin/pw: . tests Message-ID: <20151202223743.GE20169@ivaldir.etoilebsd.net> References: <201508232142.t7NLgSXX033227@repo.freebsd.org> <867fkxcbq9.fsf@desk.des.no> <20151202215958.GD20169@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tMbDGjvJuJijemkf" Content-Disposition: inline In-Reply-To: <20151202215958.GD20169@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 22:37:49 -0000 --tMbDGjvJuJijemkf Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 02, 2015 at 10:59:58PM +0100, Baptiste Daroussin wrote: > On Wed, Dec 02, 2015 at 12:48:46PM +0100, Dag-Erling Sm=F8rgrav wrote: > > Baptiste Daroussin writes: > > > Log: > > > MFC: r285133,r285136,r285137,r285156,r285157,r285158,r285256,r28531= 8,r285395, > > > r285396,r285398,r285401,r285403,r285405,r285406,r285408,r285409,r28= 5411, > > > r285412,r285413,r285415,r285418,r285430,r285433,r285434,r285442,r28= 5948, > > > r285984,r285985,r285989,r285996,r285997,r286045,r286047,r286066,r28= 6150, > > > r286151,r286152,r286154,r286155,r286156,r286157,r286173,r286196,r28= 6197, > > > r286198,r286199,r286200,r286201,r286202,r286203,r286204,r286210,r28= 6211, > > > r286217,r286218,r286258,r286259,r286341,r286775,r286982,r286986,r28= 6991, > > > r286993 > > > =20 > > > Validate most pw inputs. > >=20 > > This is a serious regression as the validation code is not locale-aware. > > I would like to see it reverted and an EN issued. Fixing it correctly > > will be a major undertaking since it would needs to support multibyte > > locales. In the meantime, I will have to replace pw on my 10.2 systems > > with the 10.1 binary. >=20 > Or a fix can be made, if you provide an example of the failing case, I wo= uld be > able to fix it and add it to the regression tests. >=20 > Bapt If that is what you were speaking about, it is fixed. https://svnweb.freebsd.org/base?view=3Drevision&revision=3D291658 Best regards, Bapt --tMbDGjvJuJijemkf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlZfcrcACgkQ8kTtMUmk6Ex+pACfb+RciUJgii7U5/8xMaZA9GQo IpAAnihYRbJ2puJHX0tpaHA5r+Zk7n4I =PKDz -----END PGP SIGNATURE----- --tMbDGjvJuJijemkf--