From owner-svn-src-head@FreeBSD.ORG  Sun May 17 18:08:23 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4B4EF289;
 Sun, 17 May 2015 18:08:23 +0000 (UTC)
Received: from kif.fubar.geek.nz (kif.fubar.geek.nz [178.62.119.249])
 by mx1.freebsd.org (Postfix) with ESMTP id 173CA1C38;
 Sun, 17 May 2015 18:08:22 +0000 (UTC)
Received: from bender.Home (97e07b11.skybroadband.com [151.224.123.17])
 by kif.fubar.geek.nz (Postfix) with ESMTPSA id 48F5ED7A6F;
 Sun, 17 May 2015 18:08:14 +0000 (UTC)
Date: Sun, 17 May 2015 19:08:10 +0100
From: Andrew Turner <andrew@fubar.geek.nz>
To: Cy Schubert <cy@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r282415 - head/usr.sbin/ntp
Message-ID: <20150517190810.4006b7bb@bender.Home>
In-Reply-To: <201505041242.t44CgrTd090709@svn.freebsd.org>
References: <201505041242.t44CgrTd090709@svn.freebsd.org>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; amd64-portbld-freebsd10.0)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 May 2015 18:08:23 -0000

On Mon, 4 May 2015 12:42:53 +0000 (UTC)
Cy Schubert <cy@FreeBSD.org> wrote:

> Author: cy
> Date: Mon May  4 12:42:52 2015
> New Revision: 282415
> URL: https://svnweb.freebsd.org/changeset/base/282415
> 
> Log:
>   Restore CPU dependent compile time conditionals.
>   
>   MFC after:	1 month (with r281143 and r282408)

Do you have any plans on fixing this before you MFC it? Specifically:
 * sizeof(char *) == 8 on arm64, powerpc64, and mips64
 * sizeof(long) == 8 on arm64, powerpc64, and mips64
 * sizeof(time_t) == 8 on arm, arm64, powerpc64, mips, and mips64
 * STR_SYSTEM is incorrect on arm, arm64, powerpc64, mips, and mips64,
   however this is now less broken as it was previously also broken on
   i386, and sparc64.

This change is only correct for amd64, i386, and sparc64.

I suspect all of the above will also be relevant on ia64. We still have
support in 10-STABLE for this so should be fixed before an MFC.

I have heard reports that NTP is broken on some of the above platforms
so they don't keep very accurate time. Can you fix this, or revert this
change until a fix can be written.

Andrew