Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Sep 2017 11:29:48 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r323538 - stable/11/lib/libc/amd64/sys
Message-ID:  <201709131129.v8DBTmD8080440@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Wed Sep 13 11:29:48 2017
New Revision: 323538
URL: https://svnweb.freebsd.org/changeset/base/323538

Log:
  MFC 322763:
  Optimize libc to get and set TLS using the RDFSBASE and RDGSBASE
  instructions, if supported both by CPU and kernel.

Added:
  stable/11/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.c
     - copied, changed from r322763, head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.c
  stable/11/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.h
     - copied unchanged from r322763, head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.h
Modified:
  stable/11/lib/libc/amd64/sys/Makefile.inc
  stable/11/lib/libc/amd64/sys/amd64_get_fsbase.c
  stable/11/lib/libc/amd64/sys/amd64_get_gsbase.c
  stable/11/lib/libc/amd64/sys/amd64_set_fsbase.c
  stable/11/lib/libc/amd64/sys/amd64_set_gsbase.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/lib/libc/amd64/sys/Makefile.inc
==============================================================================
--- stable/11/lib/libc/amd64/sys/Makefile.inc	Wed Sep 13 11:19:04 2017	(r323537)
+++ stable/11/lib/libc/amd64/sys/Makefile.inc	Wed Sep 13 11:29:48 2017	(r323538)
@@ -1,7 +1,11 @@
 #	from: Makefile.inc,v 1.1 1993/09/03 19:04:23 jtc Exp
 # $FreeBSD$
 
-SRCS+=	amd64_get_fsbase.c amd64_get_gsbase.c amd64_set_fsbase.c \
+SRCS+=	\
+	amd64_detect_rdfsgsbase.c \
+	amd64_get_fsbase.c \
+	amd64_get_gsbase.c \
+	amd64_set_fsbase.c \
 	amd64_set_gsbase.c
 
 MDASM=	vfork.S brk.S cerror.S exect.S getcontext.S \

Copied and modified: stable/11/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.c (from r322763, head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.c)
==============================================================================
--- head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.c	Mon Aug 21 17:39:12 2017	(r322763, copy source)
+++ stable/11/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.c	Wed Sep 13 11:29:48 2017	(r323538)
@@ -48,7 +48,9 @@ amd64_detect_rdfsgsbase(void)
 	if (__predict_true(state != RDFSGS_UNKNOWN))
 		return (state);
 
-	if (__getosreldate() >= P_OSREL_WRFSBASE) {
+	if (__getosreldate() >= P_OSREL_WRFSBASE ||
+	    (P_OSREL_MAJOR(__getosreldate()) == 11 && __getosreldate() >=
+	    P_OSREL_WRFSBASE_11)) {
 		do_cpuid(0x0, p);
 		if (p[0] >= 0x7) {
 			cpuid_count(0x7, 0x0, p);

Copied: stable/11/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.h (from r322763, head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.h)
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ stable/11/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.h	Wed Sep 13 11:29:48 2017	(r323538, copy of r322763, head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.h)
@@ -0,0 +1,43 @@
+/*-
+ * Copyright (c) 2017 The FreeBSD Foundation
+ * All rights reserved.
+ *
+ * This software was developed by Konstantin Belousov <kib@FreeBSD.org>
+ * under sponsorship from the FreeBSD Foundation.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#ifndef _AMD64_DETECT_RDFSGSBASE_H_
+#define _AMD64_DETECT_RDFSGSBASE_H_
+
+enum {
+	RDFSGS_UNKNOWN,
+	RDFSGS_SUPPORTED,
+	RDFSGS_UNSUPPORTED,
+};
+
+int amd64_detect_rdfsgsbase(void);
+
+#endif

Modified: stable/11/lib/libc/amd64/sys/amd64_get_fsbase.c
==============================================================================
--- stable/11/lib/libc/amd64/sys/amd64_get_fsbase.c	Wed Sep 13 11:19:04 2017	(r323537)
+++ stable/11/lib/libc/amd64/sys/amd64_get_fsbase.c	Wed Sep 13 11:29:48 2017	(r323538)
@@ -1,7 +1,11 @@
 /*-
  * Copyright (c) 2003 Peter Wemm
+ * Copyright (c) 2017 The FreeBSD Foundation
  * All rights reserved.
  *
+ * Portions of this software were developed by Konstantin Belousov
+ * under sponsorship from the FreeBSD Foundation.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ -27,11 +31,18 @@
 #include <sys/cdefs.h>
 __FBSDID("$FreeBSD$");
 
+#include <sys/types.h>
+#include <machine/cpufunc.h>
 #include <machine/sysarch.h>
+#include "amd64_detect_rdfsgsbase.h"
 
 int
 amd64_get_fsbase(void **addr)
 {
 
+	if (amd64_detect_rdfsgsbase() == RDFSGS_SUPPORTED) {
+		*addr = (void *)rdfsbase();
+		return (0);
+	}
 	return (sysarch(AMD64_GET_FSBASE, addr));
 }

Modified: stable/11/lib/libc/amd64/sys/amd64_get_gsbase.c
==============================================================================
--- stable/11/lib/libc/amd64/sys/amd64_get_gsbase.c	Wed Sep 13 11:19:04 2017	(r323537)
+++ stable/11/lib/libc/amd64/sys/amd64_get_gsbase.c	Wed Sep 13 11:29:48 2017	(r323538)
@@ -1,7 +1,11 @@
 /*-
  * Copyright (c) 2003 Peter Wemm
+ * Copyright (c) 2017 The FreeBSD Foundation
  * All rights reserved.
  *
+ * Portions of this software were developed by Konstantin Belousov
+ * under sponsorship from the FreeBSD Foundation.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ -27,11 +31,18 @@
 #include <sys/cdefs.h>
 __FBSDID("$FreeBSD$");
 
+#include <sys/types.h>
+#include <machine/cpufunc.h>
 #include <machine/sysarch.h>
+#include "amd64_detect_rdfsgsbase.h"
 
 int
 amd64_get_gsbase(void **addr)
 {
 
+	if  (amd64_detect_rdfsgsbase() == RDFSGS_SUPPORTED) {
+		*addr = (void *)rdgsbase();
+		return (0);
+	}
 	return (sysarch(AMD64_GET_GSBASE, addr));
 }

Modified: stable/11/lib/libc/amd64/sys/amd64_set_fsbase.c
==============================================================================
--- stable/11/lib/libc/amd64/sys/amd64_set_fsbase.c	Wed Sep 13 11:19:04 2017	(r323537)
+++ stable/11/lib/libc/amd64/sys/amd64_set_fsbase.c	Wed Sep 13 11:29:48 2017	(r323538)
@@ -1,7 +1,11 @@
 /*-
  * Copyright (c) 2003 Peter Wemm
+ * Copyright (c) 2017 The FreeBSD Foundation
  * All rights reserved.
  *
+ * Portions of this software were developed by Konstantin Belousov
+ * under sponsorship from the FreeBSD Foundation.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ -27,11 +31,18 @@
 #include <sys/cdefs.h>
 __FBSDID("$FreeBSD$");
 
+#include <sys/types.h>
+#include <machine/cpufunc.h>
 #include <machine/sysarch.h>
+#include "amd64_detect_rdfsgsbase.h"
 
 int
 amd64_set_fsbase(void *addr)
 {
 
+	if (amd64_detect_rdfsgsbase() == RDFSGS_SUPPORTED) {
+		wrfsbase((uintptr_t)addr);
+		return (0);
+	}
 	return (sysarch(AMD64_SET_FSBASE, &addr));
 }

Modified: stable/11/lib/libc/amd64/sys/amd64_set_gsbase.c
==============================================================================
--- stable/11/lib/libc/amd64/sys/amd64_set_gsbase.c	Wed Sep 13 11:19:04 2017	(r323537)
+++ stable/11/lib/libc/amd64/sys/amd64_set_gsbase.c	Wed Sep 13 11:29:48 2017	(r323538)
@@ -1,7 +1,11 @@
 /*-
  * Copyright (c) 2003 Peter Wemm
+ * Copyright (c) 2017 The FreeBSD Foundation
  * All rights reserved.
  *
+ * Portions of this software were developed by Konstantin Belousov
+ * under sponsorship from the FreeBSD Foundation.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ -27,11 +31,18 @@
 #include <sys/cdefs.h>
 __FBSDID("$FreeBSD$");
 
+#include <sys/types.h>
+#include <machine/cpufunc.h>
 #include <machine/sysarch.h>
+#include "amd64_detect_rdfsgsbase.h"
 
 int
 amd64_set_gsbase(void *addr)
 {
 
+	if (amd64_detect_rdfsgsbase() == RDFSGS_SUPPORTED) {
+		wrgsbase((uintptr_t)addr);
+		return (0);
+	}
 	return (sysarch(AMD64_SET_GSBASE, &addr));
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201709131129.v8DBTmD8080440>