Date: Mon, 11 Mar 2013 20:25:58 +0100 From: Attilio Rao <attilio@freebsd.org> To: Alan Cox <alc@rice.edu> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r248162 - user/attilio/vmobj-readlock/sys/vm Message-ID: <CAJ-FndC44zQZnGrznPk3_JqSOJnN7kyuk2wXHgr2djsm5ePuLA@mail.gmail.com> In-Reply-To: <513E0EF4.4050304@rice.edu> References: <201303111350.r2BDoeRI054744@svn.freebsd.org> <513E0EF4.4050304@rice.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 11, 2013 at 6:05 PM, Alan Cox <alc@rice.edu> wrote: > On 03/11/2013 08:50, Attilio Rao wrote: >> Author: attilio >> Date: Mon Mar 11 13:50:40 2013 >> New Revision: 248162 >> URL: http://svnweb.freebsd.org/changeset/base/248162 >> >> Log: >> The VM_ALLOC_IFCACHED case does not require any object locking as >> it will only go through the object page cache and return. >> Lookups in the object's page cache are correctly handled by >> the vm_page_queue_free_mtx, which will be acquired correctly in this >> case. >> Relax the locking assertion. >> > > Umm, no. The page is moving from the cache to the rtree. Insertion > into the latter requires the object to be write locked. Yeah, I figured out while I was having gym training :) Huge brainfart, I'll revert soon. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndC44zQZnGrznPk3_JqSOJnN7kyuk2wXHgr2djsm5ePuLA>